[JS] Add support to switch frame by id

SeleniumHQ · May 16, 2022 · 97aeedb · 97aeedb
1 parent 6083cc4
commit 97aeedb
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 2 deletions.
diff --git a/javascript/node/selenium-webdriver/lib/webdriver.js b/javascript/node/selenium-webdriver/lib/webdriver.js
@@ -2162,13 +2162,21 @@ class TargetLocator {
    * If the specified frame can not be found, the returned promise will be
    * rejected with a {@linkplain error.NoSuchFrameError}.
    *
-   * @param {(number|WebElement|null)} id The frame locator.
+   * @param {(number|string|WebElement|null)} id The frame locator.
    * @return {!Promise<void>} A promise that will be resolved
    *     when the driver has changed focus to the specified frame.
    */
   frame(id) {
+    let frameReference = id;
+
+    if (typeof id === "string") {
+      frameReference = this.driver_.findElement({
+        id: id
+      });
+    }
+
     return this.driver_.execute(
-      new command.Command(command.Name.SWITCH_TO_FRAME).setParameter('id', id)
+      new command.Command(command.Name.SWITCH_TO_FRAME).setParameter('id', frameReference)
     )
   }
 

diff --git a/javascript/node/selenium-webdriver/test/frame_test.js b/javascript/node/selenium-webdriver/test/frame_test.js
@@ -50,4 +50,18 @@ test.suite(function (env) {
       'This page has iframes'
     )
   })
+
+  it('can switch to a frame by id', async function () {
+    await driver.get(test.Pages.iframePage)
+    await driver.switchTo().frame("iframe1")
+    assert.strictEqual(
+      await driver.executeScript('return document.title'),
+      'We Leave From Here'
+    )
+    await driver.switchTo().parentFrame()
+    assert.strictEqual(
+      await driver.executeScript('return document.title'),
+      'This page has iframes'
+    )
+  })
 })