Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi select #644

Open
wants to merge 1 commit into
base: v3
Choose a base branch
from
Open

Multi select #644

wants to merge 1 commit into from

Conversation

dvd900
Copy link
Contributor

@dvd900 dvd900 commented Apr 5, 2019

Would be happy to port this to the electron app as well.

Credit to @Jongkeun for initial legwork.

Copy link
Member

@corevo corevo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are using yarn how is it that a package-lock.json was generated, please remove it and make sure to squash so it won't be in the history.

@dvd900
Copy link
Contributor Author

dvd900 commented Apr 8, 2019

@corevo oh, weird. Squashed it down to one commit for easier viewing.

Copy link
Member

@corevo corevo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, great work but there are a few experience improvements that are needed

  • drag n drop for the entire selection
  • holding down the primary modifier (ctrl for windows command for mac) should be additive to the selected commands, currently it has no effect (look at modifier keys to see how we handle it cross os)
  • only the last selected command should have the top border (it is used to denote where commands will be inserted when recording)

Thanks a lot for the work put into this, this looks great so far!

@tourdedave
Copy link
Contributor

@dvd900 Hey, have you had a chance to look at @corevo's improvement requirements to land this PR? I can lend a hand if you'd like.

@CLAassistant
Copy link

CLAassistant commented Nov 23, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


david califf seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants