Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make echo in single quotes #1045

Open
wants to merge 3 commits into
base: v3
Choose a base branch
from
Open

Conversation

raju249
Copy link
Member

@raju249 raju249 commented May 11, 2020

Thanks for contributing to the Selenium IDE!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Fixes #1039

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@toddtarsi
Copy link
Contributor

@raju249 - Sorry to take so long to address this. I see the WIP flag. Is this ready for review? I'd be happy to merge tbh

@raju249 raju249 changed the title WIP: Make echo in single quotes Make echo in single quotes Apr 7, 2023
@raju249
Copy link
Member Author

raju249 commented Apr 7, 2023

@toddtarsi - Yeah, I think so. I'll @AutomatedTester confirm though as I think this PR was made as part of my interview process to join his team at BrowserStack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants