Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JS] feat: Added virtual authenticator #10663

Merged
merged 4 commits into from May 31, 2022

Conversation

TamsilAmani
Copy link
Contributor

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Relates #10541

  • Added virtual authenticator for js.
  • Added tests for the same.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter
Copy link

Codecov Report

Merging #10663 (0a387e2) into trunk (97aeedb) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            trunk   #10663   +/-   ##
=======================================
  Coverage   45.60%   45.60%           
=======================================
  Files          86       86           
  Lines        5741     5741           
  Branches      274      274           
=======================================
  Hits         2618     2618           
  Misses       2849     2849           
  Partials      274      274           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97aeedb...0a387e2. Read the comment docs.

@TamsilAmani TamsilAmani marked this pull request as ready for review May 20, 2022 15:59
@sonarcloud
Copy link

sonarcloud bot commented May 31, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@harsha509 harsha509 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @TamsilAmani !

@harsha509 harsha509 merged commit 1c2240d into SeleniumHQ:trunk May 31, 2022
elgatov pushed a commit to elgatov/selenium that referenced this pull request Jun 27, 2022
* [JS] feat: Added virtual authenticator

Relates SeleniumHQ#10541

* [JS] fix: code review changes

Co-authored-by: Puja Jagani <puja.jagani93@gmail.com>
Co-authored-by: Sri Harsha <12621691+harsha509@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants