build(ansible): add options to install grafana and dashboards #5589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ansible role to add grafana to seldon cluster - allow configuring pre-loaded dashboards connected to prometheus data-source - add seldon MMS grafana dashboard - generate random password for grafana install
sakoush
approved these changes
May 15, 2024
sakoush
reviewed
May 16, 2024
| # - the grafana install, when configured | ||
| # Overwrite by passing sd_user and/or sd_password variables when running the playbook | ||
| seldon_admin_user: "admin" | ||
| seldon_random_gen_password: "{{ lookup('password', '/dev/null chars=digits length=6') }}" |
There was a problem hiding this comment.
How to fetch the randomly generated password?
There was a problem hiding this comment.
It is printed during the playbook run. If that is missed, one may run kubectl get secret --namespace seldon-monitoring grafana -o jsonpath="{.data.admin-password}" | base64 --decode ; echo to get the current password from k8s
There was a problem hiding this comment.
I've added a comment on how to get the password beyond the first run of the playbook
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an easier, automated way to deploy the MMS grafana dashboard used in various demos.
For an existing seldon core cluster, it is sufficient to run
ansible-playbook playbooks/setup-ecosystem.yaml -e full_install=false -e install_grafana=trueto add the grafana install.
For new ansible installs, the grafana dashboard is deployed by default. If may be disabled by passing
install_grafana=falseto the playbookDetails:
Which issue(s) this PR fixes: