Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include notebook nbqa as part of python lint #3548

Merged
merged 1 commit into from Aug 30, 2021
Merged

include notebook nbqa as part of python lint #3548

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 9 additions & 5 deletions python/Makefile
View file
Open in desktop
Expand Up @@ -104,19 +104,23 @@ fmt:
isort \
./ ../testing/scripts ../operator/helm ../operator/hack \
--skip proto --skip seldon_core/proto --skip .eggs --skip .tox
nbqa black ../ \
--nbqa-exclude "(proto|seldon_core/proto/|.eggs|.tox|_README\.ipynb)"
nbqa isort ../ \
--profile black --nbqa-exclude "(proto|seldon_core/proto/|.eggs|.tox|_README\.ipynb)"
nbqa black \
../ --nbqa-exclude "(proto|seldon_core/proto/|.eggs|.tox|_README\.ipynb)"
nbqa isort \
../ --profile black --nbqa-exclude "(proto|seldon_core/proto/|.eggs|.tox|_README\.ipynb)"

lint: licenses
lint:
black \
--check ./ ../testing/scripts \
--exclude "(proto|seldon_core/proto/|.eggs|.tox)"
isort \
--check-only ./ ../testing/scripts \
--skip proto --skip seldon_core/proto --skip .eggs --skip .tox
flake8
nbqa black \
../ --check --nbqa-exclude "(proto|seldon_core/proto/|.eggs|.tox|_README\.ipynb)"
nbqa isort \
../ --check-only --profile black --nbqa-exclude "(proto|seldon_core/proto/|.eggs|.tox|_README\.ipynb)"
# Check if licenses have changed
git \
--no-pager diff \
Expand Down