include notebook nbqa as part of python lint (#3548)

SeldonIO · Aug 30, 2021 · e30c82b · e30c82b
1 parent d951c34
commit e30c82b
Showing 1 changed file with 9 additions and 5 deletions.
diff --git a/python/Makefile b/python/Makefile
@@ -104,19 +104,23 @@ fmt:
 	isort \
 		./ ../testing/scripts ../operator/helm ../operator/hack \
 		--skip proto --skip seldon_core/proto --skip .eggs --skip .tox
-	nbqa black ../ \
-		--nbqa-exclude "(proto|seldon_core/proto/|.eggs|.tox|_README\.ipynb)"
-	nbqa isort ../ \
-		--profile black --nbqa-exclude "(proto|seldon_core/proto/|.eggs|.tox|_README\.ipynb)"
+	nbqa black \
+		../ --nbqa-exclude "(proto|seldon_core/proto/|.eggs|.tox|_README\.ipynb)"
+	nbqa isort \
+		../ --profile black --nbqa-exclude "(proto|seldon_core/proto/|.eggs|.tox|_README\.ipynb)"
 
-lint: licenses
+lint:
 	black \
 		--check ./ ../testing/scripts \
 		--exclude "(proto|seldon_core/proto/|.eggs|.tox)"
 	isort \
 		--check-only ./ ../testing/scripts \
 		--skip proto --skip seldon_core/proto --skip .eggs --skip .tox
 	flake8
+	nbqa black \
+		../ --check --nbqa-exclude "(proto|seldon_core/proto/|.eggs|.tox|_README\.ipynb)"
+	nbqa isort \
+		../ --check-only --profile black --nbqa-exclude "(proto|seldon_core/proto/|.eggs|.tox|_README\.ipynb)"
 	# Check if licenses have changed
 	git \
 		--no-pager diff \