Use fully-qualified name for native functions #1887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
as this is my first PR in this project and I have't found a contributing guideline, please let me know in case you need anything from me.
This PR makes use of fully-qualified names for native functions - aka prefixing them with
\- to allow optimizations through the engine. This is definitely a micro-optimization and I haven't measured it here, but it's a relatively common optimization in the PHP world these days, so I hope this is considered. E.g see https://php.watch/articles/php-zend-engine-special-inlined-functionsCheers,
Christoph