Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove base path on LineFormatter #1873

Merged
merged 4 commits into from
Apr 12, 2024
Merged

Remove base path on LineFormatter #1873

merged 4 commits into from
Apr 12, 2024

Conversation

cesarreyes3
Copy link
Contributor

OPT-IN, This makes smaller logs entries, it is easy to read too

Before

Error at /var/www/vhosts/myvhost.com/app/Models/MyModel.php:165)
[stacktrace]
 /var/www/vhosts/myvhost.com/vendor/laravel/framework/src/Illuminate/Database/Eloquent/Model.php(1475)
 /var/www/vhosts/myvhost.com/vendor/laravel/framework/src/Illuminate/Database/Eloquent/Builder.php(1218)
 /var/www/vhosts/myvhost.com/vendor/laravel/framework/src/Illuminate/Database/Eloquent/Builder.php(1199)

After

$formatter->basePath('/var/www/vhosts/myvhost.com'); //laravel has base_path()
Error at app/Models/MyModel.php:165)
[stacktrace]
 vendor/laravel/framework/src/Illuminate/Database/Eloquent/Model.php(1475)
 vendor/laravel/framework/src/Illuminate/Database/Eloquent/Builder.php(1218)
 vendor/laravel/framework/src/Illuminate/Database/Eloquent/Builder.php(1199)

@Seldaek Seldaek added this to the 3.x milestone Apr 12, 2024
@Seldaek Seldaek merged commit 24e0e45 into Seldaek:main Apr 12, 2024
16 checks passed
Seldaek added a commit that referenced this pull request Apr 12, 2024
@Seldaek
Copy link
Owner

Seldaek commented Apr 12, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants