JsonFormatter::normalize() : respect date format from Formatter #1561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Makes sense, thanks |
|
Uh, sounds like I wasn't very careful before sending the push request... Sorry for that. I basically copied the lines and pasted on your code, without checking the code style and missing the use clause for DateTimeImmutable... :( Will do it better next time, I promise! :) |
Seldaek
force-pushed
the
th_jsonformatter_use_formatdate
branch
from
2a77aef
to
4b9fdf7
Compare
|
No worries at all, easy enough to fix. The main problem was the test failures but I figured out the issue so now should be good to merge 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! :)
This seems to be a leftover from #1459: JsonFormatter is not respecting the content of FormatterInterface->dateFormat.
The problem is because JsonFormatter extends the
normalizemethod, but doesn't handleDateTimeInterfaceobjects the same wayparent::normalize()does. This PR fixes the issue. :)