Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make methods protected access level so developer can override #1516

Closed
wants to merge 1 commit into from

Conversation

milos-silni
Copy link

No description provided.

@stof
Copy link
Contributor

stof commented Nov 30, 2020

This makes the maintenance a lot harder. Allowing protected access to properties means it is almost impossible to refactor the class without it being a BC break.

Please describe the use case you have that would justify that cost.

@milos-silni
Copy link
Author

This makes the maintenance a lot harder. Allowing protected access to properties means it is almost impossible to refactor the class without it being a BC break.

Please describe the use case you have that would justify that cost.

I wanted to override writingIsTimedOut method and add option to use ms instead of seconds

@milos-silni
Copy link
Author

in that case i will create a new pull request with changes from comment above

@Seldaek Seldaek changed the base branch from master to main December 9, 2020 22:34
@Seldaek
Copy link
Owner

Seldaek commented Dec 10, 2020

Closing as #1517 is indeed a much better approach than overriding code :)

@Seldaek Seldaek closed this Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants