Skip to content

Commit

Permalink
Remove final from class declaration (#1859)
Browse files Browse the repository at this point in the history
Most (if not all) other classes in the project are not marked as final.

Although it's possible to extend the functionality of this class by using composition, it goes against how the rest of the library works for no apparent reason.

In my use case, I was trying to add a field linking the log entry to a request [as described in the Cloud Logging documentation](https://cloud.google.com/run/docs/logging#correlate-logs).
  • Loading branch information
felds committed Apr 12, 2024
1 parent 479c936 commit ee7e2fa
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/Monolog/Formatter/GoogleCloudLoggingFormatter.php
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
*
* @author Luís Cobucci <lcobucci@gmail.com>
*/
final class GoogleCloudLoggingFormatter extends JsonFormatter
class GoogleCloudLoggingFormatter extends JsonFormatter
{
protected function normalizeRecord(LogRecord $record): array
{
Expand Down

0 comments on commit ee7e2fa

Please sign in to comment.