Add return types to closures

[alexander-schranz]

Add return types to closures via @rectorphp to your composer#10547 PR.

rector.php

<?php

declare(strict_types=1);

use Rector\Core\Configuration\Option;
use Rector\TypeDeclaration\Rector\ClassMethod\AddReturnTypeDeclarationRector;
use Rector\TypeDeclaration\Rector\ClassMethod\AddVoidReturnTypeWhereNoReturnRector;
use Rector\TypeDeclaration\Rector\ClassMethod\ReturnTypeFromReturnNewRector;
use Rector\TypeDeclaration\Rector\ClassMethod\ReturnTypeFromStrictTypedCallRector;
use Rector\TypeDeclaration\Rector\ClassMethod\ReturnTypeFromStrictTypedPropertyRector;
use Rector\TypeDeclaration\Rector\Closure\AddClosureReturnTypeRector;
use Rector\TypeDeclaration\Rector\FunctionLike\ReturnTypeDeclarationRector;
use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;

return static function (ContainerConfigurator $containerConfigurator): void {
    $parameters = $containerConfigurator->parameters();
    $services = $containerConfigurator->services();

    $parameters->set(Option::PATHS, [__DIR__ . '/src']); // only tests directory
    $parameters->set(Option::PHPSTAN_FOR_RECTOR_PATH, __DIR__ . '/phpstan/config.neon');

    // basic rules
    // $parameters->set(Option::AUTO_IMPORT_NAMES, true);
    $parameters->set(Option::IMPORT_DOC_BLOCKS, true);
    $parameters->set(Option::IMPORT_SHORT_CLASSES, false);

    $services->set(AddClosureReturnTypeRector::class);
    
    // following not enabled yet:
    // $services->set(AddReturnTypeDeclarationRector::class);
    // $services->set(AddVoidReturnTypeWhereNoReturnRector::class);
    // $services->set(ReturnTypeFromReturnNewRector::class);
    // $services->set(ReturnTypeFromStrictTypedCallRector::class);
    // $services->set(ReturnTypeFromStrictTypedPropertyRector::class);

    $services->set(ReturnTypeDeclarationRector::class);
};

CI currently fails with one little phpstan issue: alexander-schranz#2

Not sure about return true here should here not be an array returned?

https://github.com/composer/composer/blob/32852304d0c8823fe535dfc5b19e68952d4a6f41/src/Composer/Repository/ComposerRepository.php#L1509

I did also run a full rector rules for adding return types but that is failing: alexander-schranz#1
But still maybe it could help in some cases to check where maybe something can still be added.

[Seldaek]

Thanks for the PR! The return true in ComposerRepository is to indicate the cache is fresh and can be read, but I guess we could perhaps read the cache in there and return the content instead of true. I'll take a closer look when merging.

[Seldaek]

Sorry for the error/commit spam, but anyway thanks again :)

[alexander-schranz]

@Seldaek No problem. Happy the PRs could be used by you.