Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore #70

Merged
merged 37 commits into from
Aug 19, 2022
Merged

Ignore #70

merged 37 commits into from
Aug 19, 2022

Conversation

digeseiso
Copy link
Contributor

@digeseiso digeseiso commented Aug 17, 2022

Contributor Comments

Added ignore for workflows folder

Pull Request Checklist

Thank you for submitting a contribution to the goat!

In order to streamline the review of your contribution we ask that you review and comply with the below requirements:

  • Rebase your branch against the latest commit of the target branch
  • If you are adding a dependency, please explain how it was chosen
  • If manual testing is needed in order to validate the changes, provide a testing plan and the expected results
  • If there is an issue associated with your Pull Request, link the issue to the PR.

@JonZeolla
Copy link
Member

The issue is early enough in the pipeline that I think we just need to figure out how other pipelines are installing deps with pipenv without hitting this bug

.gitignore Outdated Show resolved Hide resolved
etc/.jscpd.json Outdated Show resolved Hide resolved
.github/workflows/commit.yml Outdated Show resolved Hide resolved
etc/.jscpd.json Outdated Show resolved Hide resolved
@JonZeolla
Copy link
Member

The backlog task to clean up this patch version pin is https://www.wrike.com/open.htm?id=950047944

JonZeolla
JonZeolla previously approved these changes Aug 18, 2022
Copy link
Member

@JonZeolla JonZeolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to change your commit from ignore to something more meaningful when squash merging

@digeseiso digeseiso marked this pull request as ready for review August 19, 2022 10:50
@digeseiso digeseiso merged commit 89a5df3 into main Aug 19, 2022
@digeseiso digeseiso deleted the ignore branch August 19, 2022 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants