Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add exclude severities functionality #111

Merged
merged 15 commits into from Sep 15, 2021
Merged

Add exclude severities functionality #111

merged 15 commits into from Sep 15, 2021

Conversation

JonZeolla
Copy link
Member

@JonZeolla JonZeolla commented Sep 2, 2021 •
edited

Contributor Comments

Add exclude severities functionality

Pull Request Checklist

Thank you for submitting a contribution to easy_infra!

In order to streamline the review of your contribution we ask that you review and comply with the below requirements:

  • Rebase your branch against the latest commit of the target branch
  • If you are adding a dependency, please explain how it was chosen
  • If manual testing is needed in order to validate the changes, provide a testing plan and the expected results
  • If there is an issue associated with your Pull Request, align your PR
    title with this documentation

@JonZeolla JonZeolla enabled auto-merge (squash) September 2, 2021 20:29
seanctech
seanctech previously approved these changes Sep 3, 2021
View reviewed changes
Copy link
Member

@seanctech seanctech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JonZeolla JonZeolla marked this pull request as draft September 3, 2021 20:44
auto-merge was automatically disabled September 3, 2021 20:44

Pull request was converted to draft

@JonZeolla
Copy link
Member Author

JonZeolla commented Sep 7, 2021 •
edited

Blocked on:

  1. github/super-linter#1937
  2. A super-linter release
  3. A goat update.

@JonZeolla JonZeolla added blocked Unable to make progress and removed blocked Unable to make progress labels Sep 7, 2021
@JonZeolla
Copy link
Member Author

Pending SeisoLLC/goat#50

@JonZeolla JonZeolla marked this pull request as ready for review September 13, 2021 20:44
@JonZeolla JonZeolla enabled auto-merge (squash) September 14, 2021 14:10
@JonZeolla
Copy link
Member Author

@seanctech this is good to go

seanctech
seanctech approved these changes Sep 15, 2021
View reviewed changes
Copy link
Member

@seanctech seanctech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JonZeolla JonZeolla merged commit b55db41 into main Sep 15, 2021
@JonZeolla JonZeolla deleted the add-exclude-severities branch September 15, 2021 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanctech seanctech seanctech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JonZeolla @seanctech