Support --column-extra-derives
#2212
Open
+325
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karolgorecki
changed the title
--column-extra-derives
billy1624
reviewed
May 2, 2024
There was a problem hiding this comment.
Hey @karolgorecki, thanks for contributing!!
I think this PR is incomplete? I saw the codegen writer for the compact entity format is still not implemented. I will convert this as a draft PR :)
|
Do let me know if you need help! |
|
Hi @billy1624 for the compact entity format there is no column enum so it's passed but not used. We could also not pass it but then will have to change the |
|
Hi @billy1624 is it ok or I should not pass it + update the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Info
Doesn't close any issue.
Functionally related to, but not overlapping with: #1934 & #1952
New Features
--column-extra-derivesCLI option allows for adding custom derives to column enum.Bug Fixes
None.
Breaking Changes
Fully backward compatible for the end user.
Changes
None.