RedirectComponent: refactor to function component #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for scrivito-example accepted.
|
apepper
reviewed
Apr 8, 2024
|
|
||
| render() { | ||
| const link = this.props.page.get("link"); | ||
| }, [page]); |
There was a problem hiding this comment.
I think it would be better to first const link = page.get("link"); and add link to the dependency of useEffect.
Something like:
const link = page.get("link");
React.useEffect(() => {
if (!link) return;
Scrivito.load(() => Scrivito.urlFor(link)).then((url) => {
if (link.isExternal()) {
window.top.location.replace(url);
} else {
window.location.replace(url);
}
}
}, [link]);
apepper
approved these changes
May 23, 2024
| const url = link && Scrivito.urlFor(link); | ||
| Scrivito.provideComponent("Redirect", ({ page }) => { | ||
| const link = page.get("link"); | ||
| const url = link && Scrivito.urlFor(link); |
There was a problem hiding this comment.
Please move the url resolving with a load inside of the useEffect. Otherwise its possible that the useEffect is triggered twice - first with the "unresolved" urlFor(link) and then with the resolved/loaded urlFor(link).
apepper
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.