Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ansible from requirements.txt #927

Closed
wants to merge 3 commits into from

Conversation

rusko124
Copy link
Contributor

@rusko124 rusko124 commented Oct 8, 2018

At the moment I was trying to install screenly-ose(with https://www.screenly.io/install-ose.sh) on
RASPBIAN LITE, but it failed.
The reason is this problem #924.
At the moment users also have this problem if choose develop or production branch in script( expiremental branch haven't ansible in requirements files).

@vpetersson
Copy link
Contributor

@rusko124 Can you explain why this fix works? You're simply moving Ansible from the regular requirements file to the dev one.

@rusko124
Copy link
Contributor Author

rusko124 commented Oct 8, 2018

@vpetersson
Oh sure. This script before the start of the ansible-playbook, installs the ansible with the specified version. Then the ansible itself installs another version of the ansible from the requirements.txt, which leads to various errors.
Previously, there were no such errors, since the ansible in script and the ansible in requirements.txt were the same version.
Adding ansible to requirements.dev.txt is necessary for travis cl. Also travis cl no longer indicates the vulnerability of the ansible dependencies(#878).

@vpetersson
Copy link
Contributor

Oh sure. This script before the start of the ansible-playbook, installs the ansible with the specified version. Then the ansible itself installs another version of the ansible from the requirements.txt, which leads to various errors.

A better solution would be to make them consistent IMHO.

Adding ansible to requirements.dev.txt is necessary for travis cl. Also travis cl no longer indicates the vulnerability of the ansible dependencies(#878).

Yes, that's ecause it doesn't detect it. Not that it isn't still an issue.

@rusko124
Copy link
Contributor Author

rusko124 commented Oct 8, 2018

A better solution would be to make them consistent IMHO.

I do not quite understand why you need to install 2 times ansible, if ansible participates only for installation. And the requirements.txt itself directly for work screenly's processes.

Yes, that's ecause it doesn't detect it. Not that it isn't still an issue.

If we don't add ansible to requirements.dev.txt, we also get a travis cl error.

@rusko124 rusko124 closed this Oct 8, 2018
@rusko124 rusko124 deleted the req_txt_edits branch June 12, 2019 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants