Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SVA-238 | Fix for React Native Android build failure #101

Merged
merged 1 commit into from Nov 7, 2022
Merged

SVA-238 | Fix for React Native Android build failure #101

merged 1 commit into from Nov 7, 2022

Conversation

joefhall
Copy link
Collaborator

@joefhall joefhall commented Nov 5, 2022 •
edited

Description

  • There is a new known issue that can cause the React Native Android build process to fail
  • Implemented the recommended fix

Fixes SVA-238

Type of change

Please delete options that are not relevant

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

DougieWougie
DougieWougie reviewed Nov 5, 2022
View reviewed changes
Copy link
Contributor

@DougieWougie DougieWougie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great spot @joefhall - build on Android under Windows and Ubuntu 20.04.

Some might also see "> java.lang.OutOfMemoryError (no error message)" on Android but closing any running apps on the emulator fixed that.

DougieWougie
DougieWougie approved these changes Nov 5, 2022
View reviewed changes
Copy link
Contributor

@DougieWougie DougieWougie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meant to choose Approve. D'oh.

annabergin94
annabergin94 approved these changes Nov 7, 2022
View reviewed changes
Copy link
Contributor

@annabergin94 annabergin94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for me locally and fixes issues I've been having building the app

@joefhall
Copy link
Collaborator Author

joefhall commented Nov 7, 2022

Thanks @DougieWougie and @annabergin94!

@joefhall joefhall merged commit 43624b5 into main Nov 7, 2022
@joefhall joefhall deleted the fix/SVA-238-android-react-native-build-failure branch November 7, 2022 12:15
sugaith
sugaith reviewed Nov 8, 2022
View reviewed changes
Copy link

@sugaith sugaith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested here for RN 0.66.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sugaith sugaith sugaith left review comments

@DougieWougie DougieWougie DougieWougie approved these changes

@annabergin94 annabergin94 annabergin94 approved these changes

@rc-1988 rc-1988 Awaiting requested review from rc-1988

@jppferguson jppferguson Awaiting requested review from jppferguson

@CatMac228 CatMac228 Awaiting requested review from CatMac228

@g-dunlop g-dunlop Awaiting requested review from g-dunlop

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@joefhall @DougieWougie @sugaith @annabergin94