Port: Shamir-based shared recovery device #7324

AureliaDolo · 2024-05-16T15:43:37Z

Related #6090

AureliaDolo · 2024-05-17T15:03:42Z

I have to split the checklist into issues and I'll implement the postrgre version once every route has been tested with the memory impl

libparsec/crates/protocol/schema/authenticated_cmds/shamir_create_shared_recovery_device.json5

server/parsec/components/shamir.py

server/tests/api_v4/authenticated/test_shamir_recovery_setup.py

libparsec/crates/testbed/src/template/crc_hash.rs

libparsec/crates/types/src/id.rs

libparsec/crates/testbed/src/template/crc_hash.rs

server/tests/api_v4/authenticated/test_shamir_recovery_setup.py

server/parsec/components/postgresql/shamir.py

server/parsec/_parsec_pyi/ids.pyi

server/tests/api_v4/authenticated/test_shamir_recovery_setup.py

libparsec/crates/protocol/schema/authenticated_cmds/shamir_create_shared_recovery_device.json5

libparsec/crates/protocol/tests/authenticated_cmds/v4/shamir_recovery_setup.rs

server/parsec/components/memory/datamodel.py

FirelightFlagboy · 2024-05-27T13:46:03Z

server/parsec/components/shamir.py

+    # async def test_dump_current_shamir(
+    #     self, organization_id: OrganizationID
+    # ) -> dict[UserID, ShamirDump]:
+    #     raise NotImplementedError


Dead code ? can it be removed ?

server/tests/api_v4/authenticated/test_shamir_recovery_setup.py

server/tests/common/rpc.py

vxgmichel

A couple of comments, LGTM otherwise 👍

server/parsec/components/memory/datamodel.py

server/parsec/components/memory/shamir.py

server/parsec/components/shamir.py

vxgmichel · 2024-05-28T08:36:02Z

server/parsec/components/memory/shamir.py

+                    return authenticated_cmds.latest.shamir_recovery_setup.RepAlreadySet()
+
+            case VerifyCertificatesBadOutcome.INVALID_DATA:
+                return authenticated_cmds.latest.shamir_recovery_setup.RepInvalidData()


Contrary to v2, this method needs to include all the required checks:

organization exists and not expired

author exists and not revoked and not frozen

all recipients exists and not revoked

check that certificate timestamps are strictly increasing in the shamir topic

See methods in other components for reference.

mmmarcos

Just some comments. Thanks for all those docstrings and code comments! 👍

libparsec/crates/protocol/schema/authenticated_cmds/shamir_create_shared_recovery_device.json5

mmmarcos · 2024-05-28T08:25:27Z

server/parsec/components/memory/shamir.py

+    ) -> None:
+        self._data.organizations[organization_id].shamir_setup.pop(author)
+
+    async def add_recovery_setup(


Some sanity_check is probably required before calling verify_certificates: the organization exists and is not expired? author exists and is not revoked?
See for example

parsec-cloud/server/parsec/components/memory/realm.py

Lines 79 to 92 in 5364230

try:

org = self._data.organizations[organization_id]

except KeyError:

return RealmCreateStoreBadOutcome.ORGANIZATION_NOT_FOUND

if org.is_expired:

return RealmCreateStoreBadOutcome.ORGANIZATION_EXPIRED

try:

author_device = org.devices[author]

except KeyError:

return RealmCreateStoreBadOutcome.AUTHOR_NOT_FOUND

author_user = org.users[author.user_id]

if author_user.is_revoked:

return RealmCreateStoreBadOutcome.AUTHOR_REVOKED

BTW there is an ongoing discussion about these checks (error-prone, duplicated code): #7119

libparsec/crates/protocol/schema/authenticated_cmds/shamir_create_shared_recovery_device.json5

mmmarcos · 2024-05-28T08:36:39Z

libparsec/crates/protocol/schema/authenticated_cmds/shamir_create_shared_recovery_device.json5

+                // Cannot deserialize data into the expected certificate, or inconsistency
+                // between  certificates and/or threshold
+                "status": "invalid_data"


Why not expose specific status? i.e. invalid_recipient, recipient_not_in_brief, recipient_already_has_share, etc.
It seems that this is how it was defined in the RFC, but I ask just out of curiosity.
cc @vxgmichel

libparsec/crates/protocol/tests/authenticated_cmds/v4/shamir_recovery_setup.rs

FirelightFlagboy · 2024-05-31T06:43:25Z

libparsec/crates/protocol/tests/authenticated_cmds/v4/shamir_recovery_setup.rs

+    let empty_req = authenticated_cmds::shamir_recovery_setup::Req { setup: None };
+    let expected = authenticated_cmds::AnyCmdReq::ShamirRecoverySetup(empty_req.clone());


nitpick: Move the expected after let data = ... (line 78)

FirelightFlagboy · 2024-05-31T06:43:56Z

libparsec/crates/protocol/tests/authenticated_cmds/v4/shamir_recovery_setup.rs

+    let data2 = authenticated_cmds::AnyCmdReq::load(&raw2).unwrap();
+    p_assert_eq!(data2, expected);
+
+    let req = authenticated_cmds::shamir_recovery_setup::Req {


nitpick: Move the expected after let data = ... (line 110)

Co-authored-by: Marcos Medrano <786907+mmmarcos@users.noreply.github.com>

AureliaDolo requested review from a team as code owners May 16, 2024 15:43

AureliaDolo force-pushed the aurelia/shamir branch from bee2c50 to ea581bf Compare May 16, 2024 15:44

AureliaDolo marked this pull request as draft May 16, 2024 15:46

AureliaDolo self-assigned this May 16, 2024

AureliaDolo requested review from vxgmichel May 16, 2024 15:46

AureliaDolo force-pushed the aurelia/shamir branch 4 times, most recently from b34bdcb to e5ed694 Compare May 16, 2024 16:32

AureliaDolo marked this pull request as ready for review May 17, 2024 15:01

AureliaDolo commented May 17, 2024

View reviewed changes

libparsec/crates/protocol/schema/authenticated_cmds/shamir_create_shared_recovery_device.json5 Outdated Show resolved Hide resolved

AureliaDolo commented May 21, 2024

View reviewed changes

server/parsec/components/shamir.py Outdated Show resolved Hide resolved

AureliaDolo commented May 21, 2024

View reviewed changes

server/tests/api_v4/authenticated/test_shamir_recovery_setup.py Outdated Show resolved Hide resolved

AureliaDolo commented May 22, 2024

View reviewed changes

libparsec/crates/testbed/src/template/crc_hash.rs Outdated Show resolved Hide resolved

FirelightFlagboy requested changes May 22, 2024

View reviewed changes

libparsec/crates/types/src/id.rs Outdated Show resolved Hide resolved

AureliaDolo force-pushed the aurelia/shamir branch 4 times, most recently from e7b72a9 to 3047103 Compare May 23, 2024 09:52

FirelightFlagboy reviewed May 23, 2024

View reviewed changes

AureliaDolo commented May 23, 2024

View reviewed changes

server/parsec/_parsec_pyi/ids.pyi Show resolved Hide resolved

FirelightFlagboy mentioned this pull request May 23, 2024

Define python token types in specific file #7388

Open

AureliaDolo force-pushed the aurelia/shamir branch 3 times, most recently from a92c18a to 4687a91 Compare May 27, 2024 11:19

AureliaDolo commented May 27, 2024

View reviewed changes

server/tests/api_v4/authenticated/test_shamir_recovery_setup.py Outdated Show resolved Hide resolved

FirelightFlagboy reviewed May 27, 2024

View reviewed changes

FirelightFlagboy mentioned this pull request May 27, 2024

Python RPC fixture file is not sorted #7411

Closed

FirelightFlagboy reviewed May 28, 2024

View reviewed changes

server/tests/common/rpc.py Show resolved Hide resolved

vxgmichel requested changes May 28, 2024

View reviewed changes

mmmarcos reviewed May 28, 2024

View reviewed changes

AureliaDolo force-pushed the aurelia/shamir branch from 4687a91 to 04393c9 Compare May 28, 2024 11:23

FirelightFlagboy reviewed May 29, 2024

View reviewed changes

libparsec/crates/protocol/tests/authenticated_cmds/v4/shamir_recovery_setup.rs Outdated Show resolved Hide resolved

AureliaDolo force-pushed the aurelia/shamir branch 2 times, most recently from fd37bfe to bd89973 Compare May 30, 2024 14:23

FirelightFlagboy reviewed May 31, 2024

View reviewed changes

AureliaDolo and others added 19 commits May 31, 2024 11:17

Add shamir_recovery_setup schema.

1596453

Add shamir create test.

ef0f966

[Shamir] Add create setup test.

4336187

Add shamir recovery setup cmd de/serializing tests.

5ded689

Ignore unimplemented postgre tests.

2cc263f

Shamir setup: custom error for certificate verification.

7bb6896

[WIP] Use shamir reveal token instead of bytes.

95e21bb

Return error when attempting to overwrite existing shamir.

e491318

Fix de/serialization tests for shamir setup.

79086a4

Helper to setup test shamir.

ea43551

Rename shamir setup status for consistency.

8e73473

Rename shamir setup status for consistency.

7c78f91

Typos

6d22ece

Co-authored-by: Marcos Medrano <786907+mmmarcos@users.noreply.github.com>

Add doc in tests.

7b3522a

Add checks for shamir creation.

3849f49

Rename shamir errors for consistency.

36cd7d8

Add test_authenticated_shamir_recovery_setup_invalid_data test.

544bbdd

Update hex comments for shamir tests.

32188a7

Add checks for shamir setup creation.

f1a64f6

AureliaDolo force-pushed the aurelia/shamir branch from bf47390 to f1a64f6 Compare May 31, 2024 09:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Port: Shamir-based shared recovery device #7324

Port: Shamir-based shared recovery device #7324

AureliaDolo commented May 16, 2024 •

edited

AureliaDolo commented May 17, 2024

FirelightFlagboy May 27, 2024

vxgmichel left a comment

vxgmichel May 28, 2024

mmmarcos left a comment

mmmarcos May 28, 2024

mmmarcos May 28, 2024

FirelightFlagboy May 31, 2024

FirelightFlagboy May 31, 2024

	try:
	org = self._data.organizations[organization_id]
	except KeyError:
	return RealmCreateStoreBadOutcome.ORGANIZATION_NOT_FOUND
	if org.is_expired:
	return RealmCreateStoreBadOutcome.ORGANIZATION_EXPIRED

	try:
	author_device = org.devices[author]
	except KeyError:
	return RealmCreateStoreBadOutcome.AUTHOR_NOT_FOUND
	author_user = org.users[author.user_id]
	if author_user.is_revoked:
	return RealmCreateStoreBadOutcome.AUTHOR_REVOKED

		let empty_req = authenticated_cmds::shamir_recovery_setup::Req { setup: None };
		let expected = authenticated_cmds::AnyCmdReq::ShamirRecoverySetup(empty_req.clone());

Port: Shamir-based shared recovery device #7324

Are you sure you want to change the base?

Port: Shamir-based shared recovery device #7324

Conversation

AureliaDolo commented May 16, 2024 • edited

AureliaDolo commented May 17, 2024

FirelightFlagboy May 27, 2024

Choose a reason for hiding this comment

vxgmichel left a comment

Choose a reason for hiding this comment

vxgmichel May 28, 2024

Choose a reason for hiding this comment

mmmarcos left a comment

Choose a reason for hiding this comment

mmmarcos May 28, 2024

Choose a reason for hiding this comment

mmmarcos May 28, 2024

Choose a reason for hiding this comment

FirelightFlagboy May 31, 2024

Choose a reason for hiding this comment

FirelightFlagboy May 31, 2024

Choose a reason for hiding this comment

AureliaDolo commented May 16, 2024 •

edited