Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MS] Adds workspace role bulk assignment #7275

Merged
merged 3 commits into from
May 31, 2024
Merged

Conversation

Max-7
Copy link
Contributor

@Max-7 Max-7 commented May 6, 2024

closes #7083

https://www.figma.com/file/XW3SNWHV8BhPsPJpsOCV2h/Parsec-App?type=design&node-id=30161-85608&mode=design&t=dt6374A9svgzPN4L-0

Needs a little makeover.

  • Keep changes in the pull request as small as possible
  • Ensure the commit history is sanitized
  • Give a meaningful title to your PR
  • Describe your changes

@Max-7 Max-7 requested a review from a team as a code owner May 6, 2024 15:31
@Max-7 Max-7 force-pushed the ms-roles-bulk-assignment branch from 3704cd0 to 8acad08 Compare May 6, 2024 15:34
@Max-7 Max-7 force-pushed the ms-roles-bulk-assignment branch 2 times, most recently from 52de135 to 6150f88 Compare May 13, 2024 17:26
@mmmarcos
Copy link
Contributor

If this is related to #7083, can you link the issue?

@Max-7 Max-7 force-pushed the ms-roles-bulk-assignment branch from 25298c9 to 347590e Compare May 30, 2024 15:20
@fabienSvtr fabienSvtr force-pushed the ms-roles-bulk-assignment branch 3 times, most recently from 7372134 to 2ef66d2 Compare May 31, 2024 06:46
Copy link
Contributor

@Ironicbay Ironicbay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The option should not be available on revoked users
  • Text does not display properly in the popover
  • I would suggest adding the option in the UsersPage action bar when a user is selected
    Screenshot 2024-05-31 at 13 13 49

@Max-7
Copy link
Contributor Author

Max-7 commented May 31, 2024

The option should not be available on revoked users

It should. Revoked users keep their role so you may want to assign the role of a user you've revoked to someone else.

Text does not display properly in the popover

What do you mean?

I would suggest adding the option in the UsersPage action bar when a user is selected

Yeah but we can't select revoked users so it may seem a bit weird to be able to do the action from one place but not the other.

@Max-7 Max-7 added this pull request to the merge queue May 31, 2024
Merged via the queue into master with commit f3a8898 May 31, 2024
13 checks passed
@Max-7 Max-7 deleted the ms-roles-bulk-assignment branch May 31, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🚀 | Feature request]: Port: Bulk re-assignment of workspace rights
4 participants