[fix #7210]: Fix snap electron build #7220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Max-7
approved these changes
Apr 30, 2024
FirelightFlagboy
force-pushed
the
7210-fix-snap-build
branch
from
469f442
to
d96d554
Compare
FirelightFlagboy
force-pushed
the
7210-fix-snap-build
branch
4 times, most recently
from
3bf9428
to
834907d
Compare
|
FirelightFlagboy
force-pushed
the
7210-fix-snap-build
branch
2 times, most recently
from
798e2f1
to
2a8ef30
Compare
The electron app failed to build the `megashark-lib` dependency during it's `prepare` step. The workaround is to pre-package `megashark-lib` using `npm pack` and patch `client/package.json` with the generated archive.
FirelightFlagboy
force-pushed
the
7210-fix-snap-build
branch
from
2a8ef30
to
cd64b57
Compare
FirelightFlagboy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The electron app failed to build the
megashark-libdependency duringit's
preparestep.The workaround is to pre-package
megashark-libusingnpm packandpatch
client/package.jsonwith the generated archive.