Lazystream fix 4 unifiedbyblocks #5807
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pp-mo
force-pushed
the
lazystream_fix_4_unifiedbyblocks
branch
from
43a2fab
to
e125570
Compare
bouweandela
reviewed
Mar 7, 2024
lib/iris/fileformats/netcdf/saver.py
Outdated
Comment on lines
2511
to
2517
| # NOTE: the goal is to process the to-be-saved blockwise via a delayed | ||
| # operation that will return (is_masked, contains_value) for each block. | ||
| # These block-wise results are then OR-ed for each source. | ||
| # N.B. `da.map_blocks` apparently will not do this, at least not without | ||
| # `drop_axis` which seems to trigger loading of the whole source array. | ||
| # TODO: It probably *can* be done with `da.blockwise`, but I have so far | ||
| # failed to grasp how you would do that. |
There was a problem hiding this comment.
This looks like a reduction, maybe that could be useful?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5807 +/- ##
=======================================
Coverage 89.74% 89.75%
=======================================
Files 92 92
Lines 22941 22959 +18
Branches 5463 5471 +8
=======================================
+ Hits 20589 20607 +18
Misses 1620 1620
Partials 732 732 ☔ View full report in Codecov by Sentry. |
pp-mo
added
the
benchmark_this
Status update
|
⏱️ Performance Benchmark Report: 67861b8Performance shiftsFull benchmark resultsGenerated by GHA run |
|
The team are spending the next 2 weeks giving our testing infrastructure some TLC. If we haven't made further progress on this PR by the beginning of April we should look at merging as-is and getting a bugfix release out. In the meantime we'll have to encourage sufferers to use Iris 3.5. |
I also raised dask/dask#10991 |
|
Replaced by #5833 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #5753
Another attempt !