Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow boundless coordinates for bilinear and nearest regridders #276

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

stephenworsley
Copy link
Contributor

The bilinear and nearest methods do not require coordinate bounds in order for ESMF to do regridding. This PR makes it so that grids without bound information are regridable via these methods.

@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.87%. Comparing base (fa3541b) to head (c9498ea).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #276      +/-   ##
==========================================
+ Coverage   98.85%   98.87%   +0.01%     
==========================================
  Files          36       36              
  Lines        3855     3902      +47     
==========================================
+ Hits         3811     3858      +47     
  Misses         44       44              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stephenworsley stephenworsley marked this pull request as ready for review May 26, 2023 10:02
@stephenworsley stephenworsley requested a review from pp-mo May 26, 2023 10:17
@github-actions
Copy link
Contributor

@SciTools-incubator/esmf-regrid-devs This pull-request is stale due to a lack of activity in the last 90 days. Remove stale label or comment, otherwise this pull-request will close automatically in 7 days time.

@github-actions github-actions bot added the Stale: Closure warning This stale issue or pull-request has been marked for closure label Aug 25, 2023
@ESadek-MO
Copy link
Contributor

@pp-mo

@stephenworsley stephenworsley removed the Stale: Closure warning This stale issue or pull-request has been marked for closure label Aug 30, 2023
@CLAassistant
Copy link

CLAassistant commented Oct 26, 2023

CLA assistant check
All committers have signed the CLA.

* main: (29 commits)
  Bump scitools/workflows from 2024.01.0 to 2024.04.3 (SciTools-incubator#356)
  Bump peter-evans/create-pull-request from 5.0.2 to 6.0.5 (SciTools-incubator#355)
  [pre-commit.ci] pre-commit autoupdate (SciTools-incubator#336)
  Updated environment lockfiles (SciTools-incubator#344)
  Update lockfiles and fix for new esmpy (SciTools-incubator#342)
  Fix for esmpy (SciTools-incubator#353)
  Fix usage of map_blocks (SciTools-incubator#338)
  Revert "Updated environment lockfiles (SciTools-incubator#335)" (SciTools-incubator#341)
  Updated environment lockfiles (SciTools-incubator#335)
  Bump actions/cache from 3 to 4 (SciTools-incubator#333)
  Bump actions/upload-artifact from 3 to 4 (SciTools-incubator#324)
  Bump actions/stale from 8.0.0 to 9.0.0 (SciTools-incubator#322)
  fix asv (SciTools-incubator#339)
  [pre-commit.ci] pre-commit autoupdate (SciTools-incubator#330)
  Bump scitools/workflows from 2023.09.0 to 2024.01.0 (SciTools-incubator#334)
  Updated environment lockfiles (SciTools-incubator#327)
  [pre-commit.ci] pre-commit autoupdate (SciTools-incubator#328)
  Updated environment lockfiles (SciTools-incubator#304)
  Add CITATION.cff (SciTools-incubator#319)
  updated for enums (SciTools-incubator#293)
  ...

# Conflicts:
#	esmf_regrid/schemes.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants