Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin Flake8, following PyCQA/flake8-import-order#190. #223

Merged
merged 3 commits into from
Dec 6, 2022

Conversation

trexfeathers
Copy link
Contributor

@trexfeathers trexfeathers commented Nov 29, 2022

Closes #221.

flake8-import-order have now released the content in PyCQA/flake8-import-order#190, so it's now safe to use Flake8 v6. I've successfully tested this locally with nox --session flake8.

@codecov
Copy link

codecov bot commented Nov 29, 2022

Codecov Report

Merging #223 (88bfa1a) into main (fff04d0) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #223   +/-   ##
=======================================
  Coverage   99.36%   99.36%           
=======================================
  Files          28       28           
  Lines        2829     2829           
=======================================
  Hits         2811     2811           
  Misses         18       18           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@stephenworsley stephenworsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be worth re-generating the lockfiles since you're changing the requirements. Otherwise this should be good to go.

Copy link
Contributor

@stephenworsley stephenworsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@stephenworsley stephenworsley merged commit af84465 into SciTools-incubator:main Dec 6, 2022
@trexfeathers
Copy link
Contributor Author

Thanks @stephenworsley 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unpin Flake8
2 participants