New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unpin Flake8 #221

Closed

trexfeathers opened this issue Nov 25, 2022 · 0 comments · Fixed by #223

Labels

Status: Blocked Type: Infrastructure

Contributor

trexfeathers commented Nov 25, 2022 •

edited

#220 introduced the flake8 <6 pin, due to flake8-import-order incompatibilities (PyCQA/flake8-import-order#189). A fix - PyCQA/flake8-import-order#190 - is due for release soon, after which we can unpin Flake8 again.

Longer term we might also consider adopting changes made in other SciTools repos:

Using isort instead of flake8-import-order.
Removing our custom CI run for linting and just use pre-commit.ci instead.

The text was updated successfully, but these errors were encountered:

trexfeathers added Status: Blocked Type: Infrastructure labels

trexfeathers mentioned this issue

Unpin Flake8, following PyCQA/flake8-import-order#190. #223

Merged

stephenworsley closed this as completed in #223

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment