Skip to content

Commit

Permalink
Update dev dependencies & remove coverage scripts (Leaflet#6635)
Browse files Browse the repository at this point in the history
* update deps

* remove some leftovers

* remove non-working coverage config

* update git-rev-sync
  • Loading branch information
mourner authored and Schleuse committed Dec 3, 2019
1 parent da37643 commit 6d8828e
Show file tree
Hide file tree
Showing 4 changed files with 21 additions and 59 deletions.
12 changes: 0 additions & 12 deletions CONTRIBUTING.md
Expand Up @@ -5,7 +5,6 @@ Contributing to Leaflet
2. [Reporting Bugs](#reporting-bugs)
3. [Contributing Code](#contributing-code)
4. [Running the Tests](#running-the-tests)
5. [Code Coverage](#code-coverage)
6. [Improving Documentation](#improving-documentation)
7. [Code of Conduct](#code-of-conduct)
8. [Thank You](#thank-you)
Expand Down Expand Up @@ -137,17 +136,6 @@ npm test -- -- --browsers Firefox,Chrome,Safari,IE

To run the tests in a browser manually, open `spec/index.html`.

## Code Coverage

To generate a detailed report about test coverage (which helps tremendously when working on test improvements), run:

```
npm test -- --cov
```

After that, open `coverage/<environment>/index.html` in a browser to see the report.
From there you can click through folders/files to get details on their individual coverage.

## Improving Documentation

The code of the live Leaflet website that contains all documentation and examples is located in the `docs/` directory of the `master` branch
Expand Down
18 changes: 0 additions & 18 deletions bower.json

This file was deleted.

33 changes: 15 additions & 18 deletions package.json
Expand Up @@ -3,32 +3,29 @@
"version": "1.4.0",
"description": "JavaScript library for mobile-friendly interactive maps",
"devDependencies": {
"eslint": "^4.5.0",
"eslint": "^4.19.1",
"eslint-config-mourner": "^2.0.1",
"git-rev-sync": "^1.8.0",
"git-rev-sync": "^1.12.0",
"happen": "~0.3.2",
"karma": "^1.3.0",
"karma-chrome-launcher": "^2.0.0",
"karma-coverage": "~1.1.1",
"karma": "^4.1.0",
"karma-chrome-launcher": "^2.2.0",
"karma-expect": "^1.1.3",
"karma-firefox-launcher": "^1.1.0",
"karma-mocha": "^1.2.0",
"karma-phantomjs-launcher": "^1.0.2",
"karma-rollup-preprocessor": "^5.0.1",
"karma-firefox-launcher": "~1.1.0",
"karma-mocha": "^1.3.0",
"karma-phantomjs-launcher": "^1.0.4",
"karma-rollup-preprocessor": "^7.0.0",
"karma-safari-launcher": "~1.0.0",
"karma-sinon": "^1.0.5",
"leafdoc": "^1.4.1",
"mocha": "^3.1.0",
"phantomjs-prebuilt": "^2.1.12",
"mocha": "^6.1.4",
"phantomjs-prebuilt": "^2.1.16",
"prosthetic-hand": "^1.3.1",
"rollup": "^0.51.8",
"rollup": "^1.11.0",
"rollup-plugin-git-version": "0.2.1",
"rollup-plugin-json": "^2.1.0",
"rollup-watch": "^4.3.1",
"sinon": "^1.6.0",
"source-map": "^0.5.6",
"ssri": "^5.2.2",
"uglify-js": "~3.0.26"
"rollup-plugin-json": "^4.0.0",
"sinon": "^7.3.2",
"ssri": "^6.0.1",
"uglify-js": "~3.5.10"
},
"main": "dist/leaflet-src.js",
"style": "dist/leaflet.css",
Expand Down
17 changes: 6 additions & 11 deletions spec/karma.conf.js
Expand Up @@ -27,10 +27,6 @@ module.exports = function (config) {

var preprocessors = {};

if (config.cov) {
preprocessors['src/**/*.js'] = ['coverage'];
}

preprocessors['src/Leaflet.js'] = ['rollup'];

config.set({
Expand All @@ -42,7 +38,6 @@ module.exports = function (config) {
'karma-mocha',
'karma-sinon',
'karma-expect',
'karma-coverage',
'karma-phantomjs-launcher',
'karma-chrome-launcher',
'karma-safari-launcher',
Expand All @@ -64,16 +59,16 @@ module.exports = function (config) {
plugins: [
json()
],
format: 'umd',
name: 'L',
outro: outro
output: {
format: 'umd',
name: 'L',
outro: outro
}
},

// test results reporter to use
// possible values: 'dots', 'progress', 'junit', 'growl', 'coverage'
reporters: config.cov ? ['dots', 'coverage'] : ['dots'],

coverageReporter: config.cov ? {type : 'html', dir : 'coverage/'} : null,
reporters: ['dots'],

// web server port
port: 9876,
Expand Down

0 comments on commit 6d8828e

Please sign in to comment.