Update pip in GHA, rollback PR #9341 #9357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gaurav Talreja <gtalreja@redhat.com>
Signed-off-by: Gaurav Talreja <gtalreja@redhat.com>
mshriver
reviewed
Feb 8, 2022
| @@ -33,6 +33,14 @@ REPOS: | |||
| RHEL7: replace-with-rhel7-http-link | |||
| RHEL8: replace-with-rhel8-http-link | |||
| RHEL9: replace-with-rhel9-http-link | |||
| # Satellite's utils repos, and it works for 7.0 and onwards | |||
There was a problem hiding this comment.
This is a really ugly crossover in validation of the yamls, since these fields were introduced by sat6-upgrade. Not directly related to this PR or needing to be fixed in this PR. But the fact that GHA will fail for robottelo PRs because satellite6-upgrade added some fields to its repos.yaml is broken.
There was a problem hiding this comment.
Yeah! Agree but the checks were failing for upgrade scenarios collections where it's looking for setting in robottelo's confs.
mshriver
approved these changes
Feb 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
tests/upgradesfails in GHA for recently added SATUTILS_REPO and SATCLIENT_REPO variables, check Added client and utils repository support in satellite capsule and client upgrade. satellite6-upgrade#521Tested here: Gauravtalreja1#2