Skip to content

Commit

Permalink
Use temporary Javassist #328 bugfix release with 'de.scrum-master' co…
Browse files Browse the repository at this point in the history
…ordinates

GAV: de.scrum-master.org.javassist:javassist:3.27.0-GA-bugfix-328

I pushed this to Maven Central myself today because the Javassist maintainer
does not plan a new release before end of 2020-08. Until then I do not wish to
rely on a local snapshot if I share the Sarek repository with anyone else.

TODO:
  - Remove workaround after fix for #328 is released, see
    jboss-javassist/javassist#328
  - The ASM workaround also still is in the code base and the dependency in the
    POM. Either move the "repair stack map" method into a tool class or just
    delete it, then also get rid of the ByteBuddy dependency.
  • Loading branch information
kriegaex committed Jul 14, 2020
1 parent 0f5083d commit 954f5a4
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 4 deletions.
8 changes: 6 additions & 2 deletions pom.xml
Expand Up @@ -20,7 +20,9 @@
<maven.compiler.target>1.8</maven.compiler.target>

<bytebuddy.version>1.10.13</bytebuddy.version>
<javassist.version>3.27.0-GA</javassist.version>
<!-- TODO: remove after fix for https://github.com/jboss-javassist/javassist/issues/328 is released-->
<javassist.version>3.27.0-GA-bugfix-328</javassist.version>
<!--<javassist.version>3.27.0-GA</javassist.version>-->
<objenesis.version>3.1</objenesis.version>
<junit4.version>4.13</junit4.version>
<junit5.version>5.6.2</junit5.version>
Expand Down Expand Up @@ -352,7 +354,9 @@

<!-- Javassist -->
<dependency>
<groupId>org.javassist</groupId>
<!-- TODO: remove after fix for https://github.com/jboss-javassist/javassist/issues/328 is released-->
<groupId>de.scrum-master.org.javassist</groupId>
<!--<groupId>org.javassist</groupId>-->
<artifactId>javassist</artifactId>
<version>${javassist.version}</version>
</dependency>
Expand Down
4 changes: 3 additions & 1 deletion sarek-constructor-mock-javassist/pom.xml
Expand Up @@ -30,7 +30,9 @@
<dependencies>

<dependency>
<groupId>org.javassist</groupId>
<!-- TODO: remove after fix for https://github.com/jboss-javassist/javassist/issues/328 is released-->
<groupId>de.scrum-master.org.javassist</groupId>
<!--<groupId>org.javassist</groupId>-->
<artifactId>javassist</artifactId>
</dependency>
<dependency>
Expand Down
Expand Up @@ -130,7 +130,7 @@ public byte[] transform(
}

// TODO: remove after fix for https://github.com/jboss-javassist/javassist/issues/328 is released
final boolean REPAIR = true;
final boolean REPAIR = false;
if (REPAIR)
transformedBytecode = repairStackMapUsingASM(className, transformedBytecode);

Expand Down

0 comments on commit 954f5a4

Please sign in to comment.