Skip to content

Commit

Permalink
Give credit to @sheerun for coming up with the syntax.
Browse files Browse the repository at this point in the history
  • Loading branch information
SamirTalwar committed May 17, 2016
1 parent b69dc57 commit 703c534
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -73,3 +73,7 @@ Our new size?
3400732

3 MB. Busybox (approximately 1 MB) plus our application binary. That's it. No fluff, less attack surface and I can push it to my registry in no time.

---

[Thanks to @sheerun for the `NAME` and `COPY` syntax used in this project.](https://github.com/docker/docker/issues/13026#issuecomment-161322372)

4 comments on commit 703c534

@sheerun
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think moby/moby#18596 is more complete :)

@SamirTalwar
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that too but they're equivalent. Honestly I'd prefer a syntax that allows nesting a la YAML or similar so that it's much easier to validate this sort of thing.

@sheerun
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docker seems to be creating a "builder" for docker images, but I don't think it's open sourced yet:
moby/moby#18596 (comment)

@SamirTalwar
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's really cool. I hope it comes out soon. 😄

Please sign in to comment.