Add request letsencrypt certificate #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobiaslohr
requested changes
Sep 22, 2023
cli.js
Outdated
| @@ -1047,6 +1047,8 @@ program | |||
| .option('-h, --host <host>','hostname alias to register') | |||
| .option('-j, --json', 'Optional, formats the output in json') | |||
| .option('-u, --unique', 'Optional, define alias as unique, false by default') | |||
| .option('-l, --request-letsencrypt-certificate <requestLetsncrypt>', 'Optional, ' + | |||
There was a problem hiding this comment.
Boolean flags should be passed as name only arguments to overwrite the default value (false in this case). So, instead of:
sfcc-ci sandbox:alias:create --request-letsencrypt-certificate true
it should be
sfcc-ci sandbox:alias:create --request-letsencrypt-certificate
|
Thanks a lot @sanjaykesavan for the efforts! Could you please have a look at my comment (passing of Boolean flag)? |
tobiaslohr
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for request of a Let's Encrypt certificate through the sandbox alias creation as new flag
-,--request-letsencrypt-certificateto commandsfcc-ci sandbox:alias:create