[FEATURE] allow grant type to be specified for client:auth #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tobiaslohr Could we get this into the next version? It's a pitfall many folks run into when using sfcc-ci with a dw.json file present in the same dir. |
|
Any chance of getting this fix merged? |
…sword credentials when dw.json is present
sandragolden
force-pushed
the
feature/client-grant-type
branch
from
1bdf738
to
bc7bc83
Compare
|
@tobiaslohr I just updated the branch with the latest from master, any chance we can get this merged now? |
sholsinger
approved these changes
Jan 22, 2024
hnestmann
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #245
I do not see this as a breaking change because everything will continue to work normally but we have a new option that will allow you to force client_credentials grant type
Related to Resource Owner Password Credentials Authentication Failure
What PR adjusts:
Allows grant type to be specified for
client:auth. For example:sfcc-ci client:auth -t client_credentials. Default grant type will remain unchanged and is set topasswordby default.Why?
I'm running a local project where I'm running into the
Error: Authentication failed: Resource owner authentication failedmentioned in the related doc above. Because I have adw.jsonfile in my project, the grant type ofpasswordis always being used. Due to my Account Manager setup, this is throwing an error. If I force the grant type ofclient_credentials, everything works as expected because I've added the necessary permissions to my client.