Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#192 Add consistent invocation of the ensureValidToken callback #193

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

karsov-aiops
Copy link

This PR fixes the issue: #192

@tobiaslohr tobiaslohr linked an issue Jun 4, 2021 that may be closed by this pull request
@salesforce-cla
Copy link

salesforce-cla bot commented Feb 2, 2023

Thanks for the contribution! Before we can merge this, we need @karsov-aiops to sign the Salesforce.com Contributor License Agreement.

@tobiaslohr
Copy link
Contributor

Hi @karsov-aiops, thanks for the contribution! Can you please review https://github.com/SalesforceCommerceCloud/sfcc-ci/pull/193/checks? There are test cases failing. Also can you please review #193 (comment)? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ensureValidToken does NOT invoke the success callback in all cases
2 participants