Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added checkExist on error in step upload/postFile + Added getVersions check in step activateVersion #186

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

TimKara
Copy link

@TimKara TimKara commented Nov 11, 2020

This fix is to fix the following bug/error:
Error: An error occured. Try running the command again with -D,--debug flag. { res: undefined, err: Error: SSL Error: ERR_TLS_CERT_ALTNAME_INVALID at Request.onRequestResponse (C:\Development\Source\GIT\*******\build\node_modules\request\request.js:948:24)

@salesforce-cla
Copy link

Thanks for the contribution! Unfortunately we can't verify the commit author(s): Tim Kara <t***@A***.dk>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, sign the Salesforce.com Contributor License Agreement and this Pull Request will be revalidated.

@tobiaslohr
Copy link
Contributor

Thanks for contributing @TimKara! Can you please have a look at the conflicts and resolve. Also there are some tests failing:


> sfcc-ci@2.6.0 test
> npm run lint && npm run test:unit


> sfcc-ci@2.6.0 lint
> eslint --ignore-path .gitignore ./


/home/circleci/project/lib/code.js
  132:1   error  Line 132 exceeds the maximum line length of 120  max-len
  133:13  error  Expected space(s) after "if"                     keyword-spacing
  136:20  error  Expected space(s) after "if"                     keyword-spacing
  423:13  error  Expected space(s) after "if"                     keyword-spacing
  427:25  error  Expected space(s) after "if"                     keyword-spacing

✖ 5 problems (5 errors, 0 warnings)
  4 errors and 0 warnings potentially fixable with the `--fix` option.

@tobiaslohr
Copy link
Contributor

Hi @TimKara , following up here to see, if you can check the conflicts and also resolve #186 (comment).

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants