Keep feature branch integrate-commerce-sdk-react up to date (#960)

* New year, new look! (#876) * New year, new look! * Use JS to compute current year. * Small bump to max deps allowed. Needed to so that non-code changes will pass CI. Hitting the limit can be addressed later. * Update from 2.5.0 (#881) * Starting release process for 2.5.0 * allow commerce react sdk to release * bump version to 2.5.0 (#879) * bump version to 2.5.0 * bump max packages * Begin development on 2.6.0 * Set commerce-sdk-react package to private (#882) * test-commerce: comment out not-implemented customer hooks (#877) * Change padding (#899) * [Snyk] Security upgrade eslint-import-resolver-webpack from 0.10.0 to 0.13.1 (#887) * fix: packages/internal-lib-build/package.json & packages/internal-lib-build/package-lock.json to reduce vulnerabilities The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-DEBUG-3227433 * upgrade eslint-webpack-plugin-import, regen lock file Co-authored-by: Alex Vuong <alex.vuong@salesforce.com> Co-authored-by: Will Harney <62956339+wjhsf@users.noreply.github.com> * Cache SLAS callback using request processor (#884) * cache callback in request processor * fix import path * cache callback for a year * use native URLSearchParams * revert use native URLSearchParams * Rotate fingerprint ssh for deploy commerce sdk doc (#905) * Feature/megamenu fixes (#875) * [W-11996527] WIP - commit megamenu spike results / findings to feature branch * resolve search error * move default variables to constants file * cleanup code * add aria-live to menu categories * lint * implement aria live and busy * fix failing tests * update mock categories data, implement aria busy for listmenu * update mock data and fix list-menu test * lint * resolve unmounted component error * temporary testing server errors fix * set spinner opacity to 0 and increase max package value * lint * remove mock data from app code, clean up * allow padding of categories with loaded: true to bypass initial useEffect API call * fix last failing test * Update list-menu/index.jsx Co-authored-by: Will Harney <62956339+wjhsf@users.noreply.github.com> * fix aria-busy implementation and cleanup * add more test cases - when there is no root categories * remove mit license comment * add depndency array to useeffect * globally mock getcategory api call * WIP * fix tests WIP * remove all instances of setupmockserver in test files * globally mock istokenvalid AND many other cleanup items * refactor tree walking code * add locale checks and time to localstorage * WIP removing tree walking logic * remove tree walking code, update setroot and extract stale time * add catch to promise all * lint * namespace constants, remove unnecessary try catch... * final cleanup * fix lint Co-authored-by: Brian Feister <bfeister@salesforce.com> Co-authored-by: Will Harney <62956339+wjhsf@users.noreply.github.com> Co-authored-by: Kevin He <kevin.he@salesforce.com> * Mega menu fixes (#910) * Remove unnecessary catch clause. * Update copyright. * Don't return error when category is expected. * Fix bug preventing cache invalidation. * Set fetchTime when data is fetched, rather than every page load. * Update comment. * Convert promise chain to async/await for readability. * Guard against missing category items. * Move comment inside code block. * Change useEffect back to promise chain, not async/await. useEffect expects the callback to return nothing or a function; returning a promise could break things. * GitHub Actions (#854) * Add test workflow * Use actions/checkout v3 * Don't use CI image * Add step install npm dependencies * Add setup action * Set DEVELOP and RELEASE env variables * Add required shell property * Update action.yml * Update action.yml * Adding test matrix * cleanup * Split setup windows and ubuntu * Update test.yml * Update test.yml * Add Lighthouse and smoketest scripts * Not using actions/cache for now * Add generated matrix * Add missing runs-on prop to generated matrix * Add Setup Node step to generated matrix * Add Setup machine to generated matrix * Add cron schedule * Add timeout-minutes 5 * Move timeout to generate project step * Add Run tests on generated projects * Use dynamic generated-project folder * Run tests on test-project and retail-react-app-demo * Add Push Bundle step * Skip flaky test * Disable fail-fast strategy * Use env variables * Re-arrange env * Add step before push bundle * cleanup * cleanup * Use temp test-env-3 * testing slack notifs * testing * add publish to npm step * fix indent * python-dev does not exist anymore * use python2 * increase max packages * test slack notifs * add snyk cli and datadog step * update mrt user credentials * testing slack with pwa kit channel * syntax * fix conditionals * test push bundle * add push bundle step for generated * syntax * fix syntax error * update slack payload * run steps in container * testing * refactor * syntax * sudo container error * testing * update * add pip * use different docker * no container * container * testing * add user to container * fix * syntax add shell * syntax errors * remove container, use act * syntax errors * add snyk audit and other syntax stuff * extract steps to own actions * add inputs for actions * add shell for steps in actions with run * project cannot be generated in action file * updated snyk token, uncommenting code * Fix typo. * Add missing appkey property. * Use snake_case names for legibility. * Restore missing clean check * Fix skipped conversion to snake_case. * Trim trailing whitespace. * Extract conditionals to vars and clean up vars. * Change env IS_TESTABLE_TEMPLATE to more clear IS_TEMPLATE_FROM_RETAIL_REACT_APP * Fix YAML breaking conditional. * Try explicitly checking value. * Try explicitly checking true/false string values. * Try string comparisons. * Fix bad YAML. * Replace " with ' * Get ready for the prime time! * Fail fast! * Update TODOs. * Clean up npm version management. * Add TODO to merge workflows. * Update step names. * End files with newline. * Run on pull_request to support forked repos. * Only run on push for develop/release. We can assume all other branches will eventually have a PR. * Only push to MRT when actually desired. * Get that JavaScript nonsense outta here! * Check DEVELOP in step conditional, not in action execution. * Add some TODOs. * Too many newlines! Co-authored-by: yunakim714 <yunakim@salesforce.com> Co-authored-by: yunakim714 <84923642+yunakim714@users.noreply.github.com> Co-authored-by: Will Harney <wharney@salesforce.com> Co-authored-by: Will Harney <62956339+wjhsf@users.noreply.github.com> * GitHub Actions fixes (#915) * Update is not fork check * Add single quote to cron expression * Add cron docs * Remove Circle CI config, fix IS_NOT_FORK (#921) * Fix develop branch name (#923) * Fix wrong proptypes (#924) * fix wrong proptypes * Update packages/template-retail-react-app/app/components/recommended-products/index.jsx Co-authored-by: Vincent Marta <vmarta@salesforce.com> Co-authored-by: Brian Feister <47546998+bfeister@users.noreply.github.com> Co-authored-by: Vincent Marta <vmarta@salesforce.com> * Update createOrder to send SLAS USID (#920) * Update createOrder to send SLAS USID * Modify some tests to include setting the header Co-authored-by: echessman <37908171+echessman@users.noreply.github.com> * Upgrade prettier to v2 (#926) * Upgrade to prettier v2 for modern TypeScript support. * Change trailing comma to prettier v1 default. Minimizes changes during v2 upgrade. * Apply prettier v2 formatting changes. Yaaay touching all of the files! * Set end of line to LF. * Remove unnecessary map statement (#929) * fix: packages/pwa-kit-runtime/package.json & packages/pwa-kit-runtime/package-lock.json to reduce vulnerabilities (#935) The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-UAPARSERJS-3244450 Co-authored-by: snyk-bot <snyk-bot@snyk.io> * Update `develop` with v2.6.0 (#939) * Starting release process for 2.6.0 * 🚢 Release v2.6.0 (#937) * Update changelog files * Set `commerce-sdk-react-preview` as public * Version 2.6.0 * Begin development on 2.7.0 * Clean changelog files * Allow support for multiple sites concurrently w/ `commerce-sdk-react` (#911) * Namespace storage keys using the current siteId. Co-authored-by: Will Harney <62956339+wjhsf@users.noreply.github.com> * @W-11920099 Re-write 'npm push' in Typescript, warn if Node deprecated (#763) * Rewrite ancient scripts in Typescript. * Show warnings on push when using a deprecated Node version. * Automatically select a `.mobify` credentials file based on `--cloud-origin`. * Fix broken CI – confusing path to package.json in the 'dist' directory! (#946) * Reliably look up project and pwa-kit-dev package.json in scripts * fix: handle special characters in `boldString` util (#942) + Add a new util for escaping special regex characters + Apply new util to `boldString` + Add and update util tests Co-authored-by: Brian Feister <47546998+bfeister@users.noreply.github.com> * Replace isomorphic jest mocks with msw handlers (#944) * replace most manual mocks * more replacements * more replacements in addresses test * lint * resolve flaky cart test * remove some jest mocks * replace all isomorphic mocks * cleanup * fix auth modal mocks * remove timers from auth hooks test, fix password test * remove timer from create account test * add timeout * cleanup --------- Co-authored-by: Brian Feister <bfeister@salesforce.com> * Remove the PersistentCache functionality (#949) * Initial pass at PersistentCache * Drop test coverage * Change test * Update customer baskets cache when there is a basket mutation (#945) * update customer baskets cache on basket mutations * Fix layout shift for mega menu (#952) * remove custom styling * remove theme in theme file * spinners in drawer menu should be visible * Serialize category data once only (#953) * serialize data only once * remove console log --------- Co-authored-by: Brian Feister <47546998+bfeister@users.noreply.github.com> * chore: update pwa-kit-dev eslint config (#950) + Bump `eslint-plugin-react` to latest version + Auto-detect React version Co-authored-by: Adam Raya <adamraya@users.noreply.github.com> * resolving testing/merge errors * Add Shopper Experience hooks (#958) * Initial commit * Update license * Update test project to use bjnl_dev * Fix usePage hook and Refactor test page * Add usePages hook * Add usePages pdp and plp test cases * Clean up * Update Changelog & Restore `zzrf-001` config --------- Co-authored-by: Ben Chypak <bchypak@salesforce.com> * add changelog * Apply changes from commerce react sdk in feature branch (#964) * apply change from commerce react sdk in feature branch * Remove wrong changlog * keep the same as develop * linting * fix formatMessage * bump sizes temporarily * fix product list tests * fix header tests * fix add to cart modal * skip tests and low test coverate temporarily * linting --------- Co-authored-by: Will Harney <62956339+wjhsf@users.noreply.github.com> Co-authored-by: Alex Vuong <52219283+alexvuong@users.noreply.github.com> Co-authored-by: vcua-mobify <47404250+vcua-mobify@users.noreply.github.com> Co-authored-by: Vincent Marta <vmarta@salesforce.com> Co-authored-by: Pavel <65617653+GoodNightBuddy@users.noreply.github.com> Co-authored-by: Snyk bot <snyk-bot@snyk.io> Co-authored-by: Alex Vuong <alex.vuong@salesforce.com> Co-authored-by: yunakim714 <84923642+yunakim714@users.noreply.github.com> Co-authored-by: Brian Feister <bfeister@salesforce.com> Co-authored-by: Adam Raya <adamraya@users.noreply.github.com> Co-authored-by: yunakim714 <yunakim@salesforce.com> Co-authored-by: Will Harney <wharney@salesforce.com> Co-authored-by: Brian Feister <47546998+bfeister@users.noreply.github.com> Co-authored-by: echessman <37908171+echessman@users.noreply.github.com> Co-authored-by: CC ProdSec <65211003+cc-prodsec@users.noreply.github.com> Co-authored-by: Ben Chypak <bchypak@mobify.com> Co-authored-by: Oliver Brook <o.brook@salesforce.com> Co-authored-by: Brad Adams <hi@breadadams.com> Co-authored-by: Kieran Haberstock <80915722+kieran-sf@users.noreply.github.com> Co-authored-by: Ben Chypak <bchypak@salesforce.com>
SalesforceCommerceCloud · Feb 13, 2023 · 469c8e7 · 469c8e7
1 parent b1a165c
commit 469c8e7
Show file tree

Hide file tree

Showing 203 changed files with 5,377 additions and 7,181 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
diff --git a/.gitattributes b/.gitattributes
@@ -1,2 +1,2 @@
 **/package-lock.json binary linguist-generated=true
-* text=auto
+* text=auto eol=lf
diff --git a/.github/actions/check_clean/action.yml b/.github/actions/check_clean/action.yml
@@ -0,0 +1,12 @@
+name: check_clean
+runs:
+  using: composite
+  steps:
+  - name: Check Repository Clean
+    run: |-
+      # Print status for debugging on CircleCI.
+      git status
+      # Fail the build if any step leaves uncommitted changes in the repo
+      # that would prevent Lerna from publishing (Lerna gets this right).
+      git diff --exit-code
+    shell: bash
diff --git a/.github/actions/count_deps/action.yml b/.github/actions/count_deps/action.yml
@@ -0,0 +1,18 @@
+name: count_deps
+runs:
+  using: composite
+  steps:
+  - name: Count Generated Project Dependencies
+    # TODO: Can TOTAL_PACKAGES be exported in a cleaner way?
+    run: |-
+      MAX_PACKAGES="2260"
+      total=$(./scripts/count-dependencies.js generated-${{ matrix.template }})
+      echo "TOTAL_PACKAGES=${total}" >> $GITHUB_ENV
+
+      if [ "$total" -gt "$MAX_PACKAGES" ]; then
+          echo "Error: Found $TOTAL_PACKAGES installed packages (max $MAX_PACKAGES).";
+          exit 1;
+      else
+          echo "Found $TOTAL_PACKAGES installed packages (max $MAX_PACKAGES).";
+      fi
+    shell: bash
diff --git a/.github/actions/create_mrt/action.yml b/.github/actions/create_mrt/action.yml
@@ -0,0 +1,14 @@
+name: create_mrt
+inputs:
+  mobify_user:
+    description: "Mobify user email"
+  mobify_api_key:
+    description: "Mobify user API key"
+runs:
+  using: composite
+  steps:
+    - name: Create MRT credentials file
+      run: |-
+        # Add credentials file at ~/.mobify so we can upload to Mobify Cloud
+        npm run save-credentials --prefix packages/template-retail-react-app -- --user "${{inputs.mobify_user}}" --key "${{inputs.mobify_api_key}}"
+      shell: bash
diff --git a/.github/actions/datadog/action.yml b/.github/actions/datadog/action.yml
@@ -0,0 +1,16 @@
+name: datadog
+inputs:
+  datadog_api_key:
+    description: "Datadog API key"
+  TOTAL_PACKAGES:
+    description: "Total # of packages"
+runs:
+  using: composite
+  steps:
+    - name: Send metrics to Datadog
+      run : |
+        # Add a dogrc so we can submit metrics to datadog
+        printf "[Connection]\napikey = ${{inputs.datadog_api_key}}\nappkey =\n" > ~/.dogrc
+
+        dog metric post mobify_platform_sdks.generated_project_total_packages ${{ inputs.TOTAL_PACKAGES }}
+      shell: bash
diff --git a/.github/actions/lighthouse_ci/action.yml b/.github/actions/lighthouse_ci/action.yml
@@ -0,0 +1,7 @@
+name: lighthouse_ci
+runs:
+  using: composite
+  steps:
+  - name: Run Lighthouse CI on the PWA
+    run: npm run test:lighthouse --prefix packages/template-retail-react-app
+    shell: bash
diff --git a/.github/actions/publish_to_npm/action.yml b/.github/actions/publish_to_npm/action.yml
@@ -0,0 +1,21 @@
+name: publish_to_npm
+inputs:
+  NODE_AUTH_TOKEN:
+    description: "Node auth token"
+runs:
+  using: composite
+  steps:
+  # TODO: Figure out a way to specify whether to publish to "latest" or "next" tag
+  - name: Publish to NPM
+    run: |-
+      # Add NPM token to allow publishing
+      echo "//registry.npmjs.org/:_authToken=${{ inputs.NODE_AUTH_TOKEN }}" > ~/.npmrc
+
+      # Publish all changed packages. The "from-package" arg means "look
+      # at the version numbers in each package.json file and if that doesn't
+      # exist on NPM, publish"
+      npm run lerna -- publish from-package --yes --no-verify-access
+
+      # Cleanup
+      rm ~/.npmrc
+    shell: bash
diff --git a/.github/actions/push_to_mrt/action.yml b/.github/actions/push_to_mrt/action.yml
@@ -0,0 +1,18 @@
+name: push_to_mrt
+inputs:
+  CWD:
+    description: Project directory
+  TARGET:
+    description: MRT target
+runs:
+  using: composite
+  steps:
+    - name: Push Bundle to MRT
+      run: |-
+        cd ${{ inputs.CWD }}
+        project="scaffold-pwa"
+        build="build ${{ github.run_id }} on ${{ github.ref }} (${{ github.sha }})"
+        if [[ ${{ inputs.TARGET }} ]]; then
+          npm run push -- -s $project --message "$build" --target ${{ inputs.TARGET }}
+        fi
+      shell: bash
diff --git a/.github/actions/setup_ubuntu/action.yml b/.github/actions/setup_ubuntu/action.yml
@@ -0,0 +1,35 @@
+name: setup_ubuntu
+inputs:
+  cwd:
+    required: false
+    default: "${PWD}"
+description: "Setup Ubuntu Machine"
+runs:
+  using: composite
+  steps:
+    - name: Install Dependencies
+      run: |-
+        # Install system dependencies
+        sudo apt-get update -yq
+        sudo apt-get install python2 python3-pip time -yq
+        sudo pip install -U pip setuptools
+        sudo pip install awscli==1.18.85 datadog==0.40.1
+
+        # Install node dependencies
+        node ./scripts/gtime.js monorepo_install npm ci
+
+        # Build the PWA
+        npm run lerna -- run analyze-build --scope "retail-react-app"
+
+        # Report bundle sizes
+        node ./scripts/report-bundle-size.js
+
+        # Check that packages are all using the same versions of compilers, etc.
+        node ./scripts/check-dependencies.js
+
+        # Install Snyk CLI
+        sudo npm install -g snyk
+
+        # Install Lighthouse CI CLI
+        sudo npm install -g @lhci/cli
+      shell: bash
diff --git a/.github/actions/setup_windows/action.yml b/.github/actions/setup_windows/action.yml
@@ -0,0 +1,14 @@
+name: setup_windows
+inputs:
+  cwd:
+    required: false
+    default: "${PWD}"
+description: "Setup Windows Machine"
+runs:
+  using: composite
+  steps:
+    - name: Install Dependencies
+      run: |-
+        # Install node dependencies
+        npm ci
+      shell: bash
diff --git a/.github/actions/smoke_tests/action.yml b/.github/actions/smoke_tests/action.yml
@@ -0,0 +1,14 @@
+name: smoke_tests
+inputs:
+  dir:
+    required: false
+    # The path to a project to test
+    default: "./packages/template-retail-react-app"
+runs:
+  using: composite
+  steps:
+  - name: Smoke test scripts
+    run: |-
+      # Basic smoke-tests for uncommonly run scripts in a project
+      node ./scripts/smoke-test-npm-scripts.js --dir ${{ inputs.dir }}
+    shell: bash
diff --git a/.github/actions/snyk/action.yml b/.github/actions/snyk/action.yml
@@ -0,0 +1,15 @@
+name: snyk
+inputs:
+  snyk_token:
+    description: "Snyk token"
+  DEVELOP:
+    description: "Is this the 'develop' branch?"
+runs:
+  using: composite
+  steps:
+  - name: Audit Generated Project
+    run: |-
+        # Run snyk auth - authenticate snyk using environment variables to add the token
+        snyk auth ${{ inputs.snyk_token }}
+        snyk monitor --ignore-policy --remote-repo-url='https://github.com/SalesforceCommerceCloud/pwa-kit.git' --project-name='generated-scaffold-pwa'
+    shell: bash
diff --git a/.github/actions/unit_tests/action.yml b/.github/actions/unit_tests/action.yml
@@ -0,0 +1,27 @@
+name: unit_tests
+inputs:
+  cwd:
+    required: false
+    default: "${PWD}"
+description: "Run tests action description"
+runs:
+  using: composite
+  steps:
+  - name: Run tests step
+    # TODO: The pilefile policy is a legacy of CircleCI. Is it still needed?
+    run: |-
+      # Explicitly set pipefile policy. This is the default for non-windows, but seems
+      # that is needs to be set on windows to fail immediately.
+      set -eo pipefail
+
+      cd ${{ inputs.cwd }}
+
+      # Note: Each of these test commands need to be exposed on the monorepo
+      # root and *also* on the PWA package. This section is run on both.
+
+      # Ensure bundlesize is in check
+      npm run test:max-file-size
+
+      # Always run fast unit tests
+      npm run test
+    shell: bash