fix websocket alpn correctly on utls #590
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wwqgtxx <wwqgtxx@gmail.com>
nekohasekai
force-pushed
the
dev-next
branch
7 times, most recently
from
44e78fe
to
83c3454
Compare
nekohasekai
force-pushed
the
dev-next
branch
3 times, most recently
from
cbf6133
to
9d75385
Compare
nekohasekai
force-pushed
the
dev-next
branch
3 times, most recently
from
d2e2372
to
6879def
Compare
nekohasekai
force-pushed
the
dev-next
branch
15 times, most recently
from
ec11e99
to
404f8d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on PR XTLS/Xray-core#1256
please read the origin PR for complete description.
credits: @HirbodBehnam
Fixes utls not setting alpn correctly when using utls.
Could be a major filtering hazard.
Also without this fix connection is not established when using CDN (as alpn is not set correctly).
Logs are based on using CF as CDN.
client config:
{ "log": { "level": "info", "timestamp": true }, "route": { "geoip": { "path": "geoip.db", "download_url": "https://github.com/soffchen/sing-geoip/releases/latest/download/geoip.db" }, "geosite": { "path": "geosite.db", "download_url": "https://github.com/soffchen/sing-geosite/releases/latest/download/geosite.db" }, "rules": [ { "geosite": ["cn", "private"], "outbound": "direct" }, { "geoip": ["cn", "private"], "outbound": "direct" } ] }, "inbounds": [ { "type": "mixed", "tag": "mixed-in", "listen": "::", "listen_port": 10000, "domain_strategy": "ipv4_only", "tcp_fast_open": true, "sniff": true, "sniff_override_destination": true } ], "outbounds": [ { "type": "vless", "tag": "proxy", "server": "sudbdomain.domain.tld", "server_port": 443, "uuid": "c74ffa38-ea77-11ed-9c46-d7588d9ee022", "flow": "", "network": "tcp", "tls": { "enabled": true, "server_name": "sudbdomain.domain.tld", "utls": { "enabled": true, "fingerprint": "chrome" } }, "packet_encoding": "xudp", "transport": { "type": "ws", "path": "/testing", "early_data_header_name": "Sec-WebSocket-Protocol", "headers": { "Host": "sudbdomain.domain.tld" } } }, { "type": "direct", "tag": "direct" }, { "type": "block", "tag": "block" } ] }without setting utls object in client config:
With utls, without this fix:
with utls, with this fix: