Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documentation: Add distro GOPROXY note #1648

Open
wants to merge 24 commits into
base: dev-next
Choose a base branch
from

Conversation

Someone-Practice
Copy link

I'm not sure whether note or warning will be more suitable.

nekohasekai and others added 24 commits April 1, 2024 15:01
The `process_path` rule of sing-box is inherited from Clash,
the original code uses the local system's path format (e.g. `\Device\HarddiskVolume1\folder\program.exe`),
but when the device has multiple disks, the HarddiskVolume serial number is not stable.

This change make QueryFullProcessImageNameW output a Win32 path (such as `C:\folder\program.exe`),
which will disrupt the existing `process_path` use cases in Windows.
For historical reasons, sing-box's `domain_suffix` rule matches literal prefixes instead of the same as other projects.

This change modifies the behavior of `domain_suffix`: If the rule value is prefixed with `.`,
the behavior is unchanged, otherwise it matches `(domain|.+\.domain)` instead.
Signed-off-by: 气息 <qdshizh@gmail.com>
Signed-off-by: Someone-Practice <152876092+Someone-Practice@users.noreply.github.com>
@nekohasekai nekohasekai force-pushed the dev-next branch 6 times, most recently from bf612be to 12e4ec5 Compare April 12, 2024 02:41
@nekohasekai nekohasekai force-pushed the dev-next branch 30 times, most recently from 954a7d8 to 5960c25 Compare May 31, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants