Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Use ISO8601 Timestamp Format in Logs #1538

Closed
wants to merge 29 commits into from

Conversation

Ryananana
Copy link

nekohasekai and others added 17 commits February 29, 2024 13:06
The `process_path` rule of sing-box is inherited from Clash,
the original code uses the local system's path format (e.g. `\Device\HarddiskVolume1\folder\program.exe`),
but when the device has multiple disks, the HarddiskVolume serial number is not stable.

This change make QueryFullProcessImageNameW output a Win32 path (such as `C:\folder\program.exe`),
which will disrupt the existing `process_path` use cases in Windows.
For historical reasons, sing-box's `domain_suffix` rule matches literal prefixes instead of the same as other projects.

This change modifies the behavior of `domain_suffix`: If the rule value is prefixed with `.`,
the behavior is unchanged, otherwise it matches `(domain|.+\.domain)` instead.
@nekohasekai nekohasekai force-pushed the dev-next branch 4 times, most recently from 6047578 to 138289f Compare March 12, 2024 07:12
@nekohasekai nekohasekai force-pushed the dev-next branch 9 times, most recently from 716d8b2 to 3cc49ee Compare March 17, 2024 13:44
@nekohasekai nekohasekai force-pushed the dev-next branch 9 times, most recently from 79e088f to 0cfc55a Compare May 10, 2024 09:54
@nekohasekai nekohasekai force-pushed the dev-next branch 4 times, most recently from 79c0361 to 2e24f6a Compare May 18, 2024 09:28
Signed-off-by: Ryananana <36809659+Ryananana@users.noreply.github.com>
Signed-off-by: Ryananana <36809659+Ryananana@users.noreply.github.com>
Signed-off-by: Ryananana <36809659+Ryananana@users.noreply.github.com>
Signed-off-by: Ryananana <36809659+Ryananana@users.noreply.github.com>
Signed-off-by: Ryananana <36809659+Ryananana@users.noreply.github.com>
Signed-off-by: Ryananana <36809659+Ryananana@users.noreply.github.com>
Signed-off-by: Ryananana <36809659+Ryananana@users.noreply.github.com>
Signed-off-by: Ryananana <36809659+Ryananana@users.noreply.github.com>
Signed-off-by: Ryananana <36809659+Ryananana@users.noreply.github.com>
Signed-off-by: Ryananana <36809659+Ryananana@users.noreply.github.com>
Signed-off-by: Ryananana <36809659+Ryananana@users.noreply.github.com>
@nekohasekai nekohasekai force-pushed the dev-next branch 3 times, most recently from 32e5f85 to 5ff7006 Compare May 25, 2024 03:30
@Ryananana Ryananana closed this May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants