-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(pod): convert component code to typescript #5451
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 64734b6:
|
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
ec2e88b
to
399ac6b
Compare
Excluding pod spec file
399ac6b
to
9e2facd
Compare
Due to issue with storybook where visiting a story via a url with args set using url parameters does not work properly.
a9ef005
to
2365c0e
Compare
f80d9ef
to
59f8fc0
Compare
5b24d03
98a2732
to
64734b6
Compare
Proposed behaviour
Pod
to typescriptPod
such that ifonEdit
is a string, render edit button as aLink
with ahref
instead of ato
prop - which was deprecated some time ago (see commit for details)title
,subtitle
,footer
andchildren
props - to enzyme tests.Grid
's E2E cypress tests - which usePod
, to be more generic so they are independent.Current behaviour
Pod
is written in javascript and its test stores file is written in MDXChecklist
d.ts
file added or updated if requiredQA
Additional context
Pod
tests will be refactored to typescript in a separate PR - due to the complexity of the file.Testing instructions