Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEC-000: Use NVM on GH Action. #868

Merged
merged 2 commits into from Apr 6, 2022
Merged

DEC-000: Use NVM on GH Action. #868

merged 2 commits into from Apr 6, 2022

Conversation

sherakama
Copy link
Member

READY FOR REVIEW

Comment on lines +42 to +46
- name: Setup node
uses: actions/setup-node@v2
with:
node-version-file: '.nvmrc'

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks right. I'm not sure how I could test it locally.

@sherakama
Copy link
Member Author

This might help 🤷 but we also might have to update our dependencies.

Copy link
Contributor

@jenbreese jenbreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gtg

@jenbreese jenbreese merged commit b7528f5 into master Apr 6, 2022
@jenbreese jenbreese deleted the sherakama-patch-1 branch April 6, 2022 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants