Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

137 setuptools is not installing requirements properly #138

Conversation

emlynjdavies
Copy link
Collaborator

@emlynjdavies emlynjdavies commented Sep 21, 2023

This is a PR to merge into #129

A switch to poetry-managed dependencies and install, instead of setuptools and requirements.txt: https://mathdatasimplified.com/2023/06/12/poetry-a-better-way-to-manage-python-dependencies/

Note:

Tensorflow doesn't work properly on the gihub windows test when installing with poetry (despite working locally on a windows machine). It does work on github when installing with pip, so I think putting a ubuntu test using poetry and a windows test using pip is satisfactory for now. This way we can test pyopia functionality in both windows and linux.


A check that a pip install of pyopia from github uses the correct pyopia version number:

pip install git+https://github.com/SINTEF/pyopia.git@137-setuptools-is-not-installing-requirements-properly

Gives expected version, and means there is backwards compatibility for the 'user install'.

Updates to developer install

Developer install should be done using:

poetry install

(instead of the old python setup.py develop)
and dependencies added using poetry add. It is encouraged to commit the poetry.lock file if you change or update dependencies.

Tests can be run locally using:

poetry run pytest

(instead of the old python setup.py test

@emlynjdavies emlynjdavies linked an issue Sep 21, 2023 that may be closed by this pull request
@emlynjdavies emlynjdavies changed the base branch from main to 129-make-high-level-admin-cmd-line-entry-points September 21, 2023 18:55
@emlynjdavies emlynjdavies self-assigned this Sep 21, 2023
@emlynjdavies emlynjdavies added enhancement New feature or request dependencies Pull requests that update a dependency file labels Sep 23, 2023
@emlynjdavies emlynjdavies marked this pull request as ready for review September 23, 2023 20:46
@emlynjdavies emlynjdavies added this to the Version 1 milestone Sep 23, 2023
@emlynjdavies emlynjdavies linked an issue Sep 24, 2023 that may be closed by this pull request
pyproject.toml Show resolved Hide resolved
README.md Show resolved Hide resolved
@emlynjdavies emlynjdavies marked this pull request as ready for review September 25, 2023 16:00
@emlynjdavies emlynjdavies merged commit 5a4fc50 into 129-make-high-level-admin-cmd-line-entry-points Sep 25, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

setuptools is not installing requirements properly Warnings in Tests
2 participants