Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minimum version check for version id dependencies #3767

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

leboff
Copy link
Contributor

@leboff leboff commented Mar 27, 2024

Add the same minimum version check that namespace/version dependencies get to 04t version id dependencies

@leboff leboff requested a review from a team as a code owner March 27, 2024 19:46
@yippie
Copy link
Contributor

yippie commented May 10, 2024

This appears to be an alternative fix to the same issue we are both having that I tried solving in a different way #3671

@yippie
Copy link
Contributor

yippie commented May 10, 2024

@jstvz @davidmreed can we please get one of these merged so that dependency install is much more efficient and doesn't downgrade.

@vsbharath
Copy link
Contributor

vsbharath commented May 17, 2024

@yippie @leboff We have reviewed the pull request. Currently, we do not plan to alter the default behavior of Salesforce concerning the installation of unlocked packages. Instead, we propose treating this as a potential new feature for CumulusCI rather than a bug.

For us to consider incorporating this feature, it must meet the following criteria:

  1. Include an option to override the default Salesforce behavior for installing unlocked packages, allowing the installation of lower versions of packages on the organization.
  2. Ensure test coverage for get_package_from_version and the changes in branches here. Additionally, please mock the response for tests regarding the query.

Let us know if you have any questions about this feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants