Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update transforms.py #3625

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Update transforms.py #3625

wants to merge 4 commits into from

Conversation

GeekStewie
Copy link

  • Updated FindReplaceIdSpec to get the first column of the select statement instead of ID

@GeekStewie
Update transforms.py
8d1f341 
- Updated FindReplaceIdSpec to get the first column of the select statement instead of ID
@GeekStewie GeekStewie marked this pull request as ready for review July 18, 2023 20:33
@GeekStewie GeekStewie requested a review from a team as a code owner July 18, 2023 20:33
davidmreed
davidmreed requested changes Jul 31, 2023
View reviewed changes
cumulusci/core/source_transforms/transforms.py Show resolved Hide resolved
cumulusci/core/source_transforms/transforms.py Outdated Show resolved Hide resolved
cumulusci/core/source_transforms/transforms.py
@@ -2,6 +2,7 @@
import functools
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also update the tests?

@davidmreed
Copy link
Contributor

@GeekStewie My apologies, I thought that I had submitted a review for you and it was sitting in Pending state.

@jstvz jstvz added oss-contribution internal Pull requests from IPDE team and removed internal Pull requests from IPDE team labels May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidmreed davidmreed davidmreed requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
cla:signed oss-contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@GeekStewie @davidmreed @jstvz