Use local version of jacoco to avoid issues with branch coverage and Jetpack Compose #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Luca-Engel
approved these changes
Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a local maven repository to the project, in the libs directory. It contains a custom version of Jacoco that fixes issues with Jetpack Compose (very low branch coverage due to "invisible" branches being detected in Composables). This Jacoco version was built locally from PR jacoco/jacoco#1259 , and the project is configured to use it instead of the default Jacoco version from the global maven repository.
Note that a first attempt to do this was made in the now deleted branch jacoco, but due to some weird issue with a commit, Cirrus CI could no longer clone this branch. Cirrus CI seems to be using the library go-git, which has an obscure bug which sometimes prevent cloning from running (go-git/go-git#495). Because of this issue, it was decided that it would be simpler to just recreate another branch and do a single clean commit, which seems to have fixed the issue with go-git.