Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Upgrade wrap-ansi to 9.0.0, remove @types/wrap-ansi #1402

Closed
wants to merge 1 commit into from

Conversation

donmccurdy
Copy link

Updates wrap-ansi to the latest version, which includes types, and removes @types/wrap-ansi.

Context: donmccurdy/glTF-Transform#1201

Thank you!

@SBoudrias
Copy link
Owner

Hi the packages update didn't commit the cache which is breaking CI (the yarn cache is committed in the repo for easy use offline.)

But as far as I know, wrap-ansi and the other non-updated dependencies are ESM-only, which prevents us updating without breaking users still on CJS (the majority of them.)

@donmccurdy
Copy link
Author

Ah, so I should have committed those files in the PR too? Good to know, thanks!

But as far as I know, wrap-ansi and the other non-updated dependencies are ESM-only...

Correct that wrap-ansi v9 is ESM-only, and understood that this would be a blocker. I'll close the PR in that case.

Looking forward to Node.js v22. 😅

@donmccurdy donmccurdy closed this May 3, 2024
@donmccurdy donmccurdy deleted the deps/wrap-ansi-9.0.0 branch May 3, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants