Fix flickering #1379
Merged
Fix flickering #1379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1379 +/- ##
==========================================
+ Coverage 94.46% 97.09% +2.62%
==========================================
Files 53 53
Lines 4556 4605 +49
Branches 772 799 +27
==========================================
+ Hits 4304 4471 +167
+ Misses 247 132 -115
+ Partials 5 2 -3 ☔ View full report in Codecov by Sentry. |
|
Ahh nice! This is a very clever find 👏🏻 The flickering was driving me crazy, and I thought it was a complex issue #1127. Thanks!! |
|
Latest release include your fix - thanks again! |
onsclom
added a commit
to vercel/vercel
that referenced
this pull request
Apr 5, 2024
These updates include SBoudrias/Inquirer.js#1379 which fixes flickering
onsclom
added a commit
to vercel/vercel
that referenced
this pull request
Apr 5, 2024
These updates include SBoudrias/Inquirer.js#1379 which fixes flickering
kodiakhq bot
pushed a commit
to vercel/vercel
that referenced
this pull request
Apr 5, 2024
Various UI components would flicker upon re-rendering in unoptimized terminals as OSX's stock terminal app. This change bumps these components to include [this fix](SBoudrias/Inquirer.js#1379). ## Before https://github.com/vercel/vercel/assets/8485687/352ce43e-9a01-4290-a4c8-8826aebf859a ## After https://github.com/vercel/vercel/assets/8485687/9e2eb071-0f7c-4d5a-adf6-735b30bcc294
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various UI components would flicker upon being re-rendered. This fixes that by delaying screen clearing until necessary.
Before
Screen.Recording.2024-04-04.at.5.07.15.PM.mov
After
Screen.Recording.2024-04-04.at.5.09.26.PM.mov