Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CommonJS file content #1219

Merged
merged 1 commit into from May 4, 2023

Conversation

LitoMore
Copy link
Sponsor Collaborator

@LitoMore LitoMore commented May 4, 2023

Fixes #1218

This is a quick fix for CommonJS files. We could consider using other tools in the future.

@LitoMore LitoMore force-pushed the fix-commonjs-file-content branch from be80d84 to 7a9f716 Compare May 4, 2023 12:20
@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (fca9909) 78.80% compared to head (7a9f716) 78.80%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1219   +/-   ##
=======================================
  Coverage   78.80%   78.80%           
=======================================
  Files          34       34           
  Lines        3496     3496           
  Branches      558      558           
=======================================
  Hits         2755     2755           
  Misses        187      187           
  Partials      554      554           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@LitoMore LitoMore requested a review from SBoudrias May 4, 2023 12:33
Copy link
Owner

@SBoudrias SBoudrias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh, TS and ESM/commonjs interop is so painful 🤦🏻

Thanks a ton for the help!

@SBoudrias SBoudrias merged commit 8000e15 into SBoudrias:master May 4, 2023
8 checks passed
@LitoMore LitoMore deleted the fix-commonjs-file-content branch May 4, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The dist files for CommonJS are not correct
2 participants