Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draft] Re-written inquirer package with new prompts #1173

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

SBoudrias
Copy link
Owner

@SBoudrias SBoudrias commented Oct 5, 2022

WIP rewriting the core features of the main inquirer package on top of the new prompt system.

Goal is removing run-async and rxjs to ship a smaller/simpler package. But keep the rest backward compatible as much as possible.

Current problem:

  • Typescript makes it hard to get strict typings; e.g. add confirm prompt in and it'll start failing.

@SBoudrias SBoudrias force-pushed the inquirer-canary branch 2 times, most recently from 0015160 to 590a6cc Compare October 6, 2022 21:12
@SBoudrias SBoudrias force-pushed the inquirer-canary branch 2 times, most recently from 70f71f2 to 44b6c80 Compare October 28, 2022 22:05
@codecov
Copy link

codecov bot commented Oct 28, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.49%. Comparing base (0dfa6bd) to head (8fe03bc).
Report is 7 commits behind head on master.

❗ Current head 8fe03bc differs from pull request most recent head 1e1e40d. Consider uploading reports for the commit 1e1e40d to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1173       +/-   ##
===========================================
- Coverage   94.46%   81.49%   -12.98%     
===========================================
  Files          53       39       -14     
  Lines        4556     4663      +107     
  Branches      772      677       -95     
===========================================
- Hits         4304     3800      -504     
+ Misses        247      193       -54     
- Partials        5      670      +665     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SBoudrias SBoudrias force-pushed the inquirer-canary branch 6 times, most recently from 2be09bb to 728f20e Compare November 10, 2022 19:58
@SBoudrias SBoudrias changed the title WIP Re-written inquirer package [Draft] Re-written inquirer package with new prompts May 6, 2023
@SBoudrias SBoudrias marked this pull request as draft May 6, 2023 19:50
@SBoudrias SBoudrias force-pushed the inquirer-canary branch 3 times, most recently from fb3df11 to 8fe03bc Compare May 24, 2023 17:18
@SBoudrias SBoudrias force-pushed the inquirer-canary branch 3 times, most recently from 5dbda65 to 1e81710 Compare March 4, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant