Chore(all): Stricter linting rules from unicorn

.eslintrc.json

@@ -50,11 +50,19 @@
     "import/order": "error",
     "prettier/prettier": "error",
     "unicorn/better-regex": "error",
+    "unicorn/explicit-length-check": "error",
     "unicorn/no-abusive-eslint-disable": "error",
+    "unicorn/no-new-array": "error",
+    "unicorn/numeric-separators-style": "error",
+    "unicorn/prefer-at": "error",
+    "unicorn/prefer-includes": "error",
     "unicorn/prefer-module": "error",
     "unicorn/prefer-node-protocol": "error",
+    "unicorn/prefer-number-properties": "error",
     "unicorn/prefer-regexp-test": "error",
-    "unicorn/prefer-string-replace-all": "error"
+    "unicorn/prefer-spread": "error",
+    "unicorn/prefer-string-replace-all": "error",
+    "unicorn/prefer-ternary": "error"
   },
   "overrides": [
     {

packages/core/src/lib/Separator.mts

@@ -7,7 +7,7 @@ import figures from '@inquirer/figures';
  */
 
 export class Separator {
-  readonly separator = chalk.dim(new Array(15).join(figures.line));
+  readonly separator = chalk.dim(Array.from({ length: 15 }).join(figures.line));
   readonly type = 'separator';
 
   constructor(separator?: string) {

packages/core/src/lib/pagination/lines.mts

@@ -20,7 +20,7 @@ function split(content: string, width: number) {
 function rotate<T>(count: number, items: readonly T[]): readonly T[] {
   const max = items.length;
   const offset = ((count % max) + max) % max;
-  return items.slice(offset).concat(items.slice(0, offset));
+  return [...items.slice(offset), ...items.slice(0, offset)];
 }
 
 /**
@@ -58,7 +58,7 @@ export function lines<T>({
   const renderItemAt = (index: number) => split(renderItem(layoutsInPage[index]!), width);
 
   // Create a blank array of lines for the page
-  const pageBuffer = new Array(pageSize);
+  const pageBuffer = Array.from({ length: pageSize });
 
   // Render the active item to decide the position
   const activeItem = renderItemAt(requested).slice(0, pageSize);

packages/core/src/lib/pagination/lines.test.mts

@@ -19,7 +19,7 @@ describe('lines(...)', () => {
       isActive: boolean;
       index: number;
     }): string =>
-      new Array(itemHeight)
+      Array.from({ length: itemHeight })
         .fill(0)
         .map((_, i) => {
           if (i === 0) {

packages/core/src/lib/screen-manager.mts

@@ -30,7 +30,7 @@ export default class ScreenManager {
     // rl.line (mainly because of the password prompt), so just rely on it's
     // length.
     let prompt = rawPromptLine;
-    if (this.rl.line.length) {
+    if (this.rl.line.length > 0) {
       prompt = prompt.slice(0, -this.rl.line.length);
     }
 

packages/inquirer/examples/checkbox.js

@@ -55,7 +55,7 @@ inquirer
         },
       ],
       validate(answer) {
-        if (answer.length < 1) {
+        if (answer.length === 0) {
           return 'You must choose at least one topping.';
         }
 

packages/inquirer/examples/long-list.js

@@ -4,7 +4,9 @@
 
 import inquirer from '../lib/inquirer.js';
 
-const choices = Array.apply(0, new Array(26)).map((x, y) => String.fromCharCode(y + 65));
+const choices = Array.apply(0, Array.from({ length: 26 })).map((x, y) =>
+  String.fromCharCode(y + 65),
+);
 choices.push('Multiline option 1\n  super cool feature \n  more lines');
 choices.push('Multiline option 2\n  super cool feature \n  more lines');
 choices.push('Multiline option 3\n  super cool feature \n  more lines');

packages/inquirer/examples/pizza.js

@@ -44,7 +44,7 @@ const questions = [
     name: 'quantity',
     message: 'How many do you need?',
     validate(value) {
-      const valid = !isNaN(parseFloat(value));
+      const valid = !Number.isNaN(Number.parseFloat(value));
       return valid || 'Please enter a number';
     },
     filter: Number,

packages/inquirer/lib/objects/choice.js

@@ -26,10 +26,7 @@ export default class Choice {
       });
     }
 
-    if (typeof val.disabled === 'function') {
-      this.disabled = val.disabled(answers);
-    } else {
-      this.disabled = val.disabled;
-    }
+    this.disabled =
+      typeof val.disabled === 'function' ? val.disabled(answers) : val.disabled;
   }
 }

packages/inquirer/lib/objects/separator.js

@@ -11,7 +11,7 @@ import figures from '@inquirer/figures';
 export default class Separator {
   constructor(line) {
     this.type = 'separator';
-    this.line = chalk.dim(line || new Array(15).join(figures.line));
+    this.line = chalk.dim(line || Array.from({ length: 15 }).join(figures.line));
   }
 
   /**

packages/inquirer/lib/prompts/base.js

@@ -166,11 +166,10 @@ export default class Prompt {
       this.status !== 'answered'
     ) {
       // If default password is supplied, hide it
-      if (this.opt.type === 'password') {
-        message += chalk.italic.dim('[hidden] ');
-      } else {
-        message += chalk.dim('(' + this.opt.default + ') ');
-      }
+      message +=
+        this.opt.type === 'password'
+          ? chalk.italic.dim('[hidden] ')
+          : chalk.dim('(' + this.opt.default + ') ');
     }
 
     return message;

packages/inquirer/lib/prompts/checkbox.js

@@ -248,11 +248,8 @@ function renderChoices(choices, pointer) {
       })`;
     } else {
       const line = getCheckbox(choice.checked) + ' ' + choice.name;
-      if (i - separatorOffset === pointer) {
-        output += chalk.cyan(figures.pointer + line);
-      } else {
-        output += ' ' + line;
-      }
+      output +=
+        i - separatorOffset === pointer ? chalk.cyan(figures.pointer + line) : ' ' + line;
     }
 
     output += '\n';

packages/inquirer/lib/prompts/editor.js

@@ -54,11 +54,10 @@ export default class EditorPrompt extends Base {
     let bottomContent = '';
     let message = this.getQuestion();
 
-    if (this.status === 'answered') {
-      message += chalk.dim('Received');
-    } else {
-      message += chalk.dim('Press <enter> to launch your preferred editor.');
-    }
+    message +=
+      this.status === 'answered'
+        ? chalk.dim('Received')
+        : chalk.dim('Press <enter> to launch your preferred editor.');
 
     if (error) {
       bottomContent = chalk.red('>> ') + error;

packages/inquirer/lib/prompts/expand.js

@@ -209,7 +209,7 @@ export default class ExpandPrompt extends Base {
       );
     }
 
-    if (errors.length) {
+    if (errors.length > 0) {
       throw new Error(
         'Duplicate key error: `key` param must be unique. Duplicates: ' +
           [...new Set(errors)].join(','),

packages/inquirer/lib/prompts/input.js

@@ -47,11 +47,7 @@ export default class InputPrompt extends Base {
     const { transformer } = this.opt;
     const isFinal = this.status === 'answered';
 
-    if (isFinal) {
-      appendContent = this.answer;
-    } else {
-      appendContent = this.rl.line;
-    }
+    appendContent = isFinal ? this.answer : this.rl.line;
 
     if (transformer) {
       message += transformer(appendContent, this.answers, { isFinal });

packages/inquirer/lib/prompts/number.js

@@ -21,6 +21,6 @@ export default class NumberPrompt extends Input {
     }
 
     // If the input was invalid return the default value.
-    return this.opt.default == null ? NaN : this.opt.default;
+    return this.opt.default == null ? Number.NaN : this.opt.default;
   }
 }

packages/inquirer/lib/prompts/password.js

@@ -14,7 +14,7 @@ function mask(input, maskChar) {
     return '';
   }
 
-  return new Array(input.length + 1).join(maskChar);
+  return Array.from({ length: input.length + 1 }).join(maskChar);
 }
 
 export default class PasswordPrompt extends Base {
@@ -55,11 +55,10 @@ export default class PasswordPrompt extends Base {
     let message = this.getQuestion();
     let bottomContent = '';
 
-    if (this.status === 'answered') {
-      message += this.getMaskedValue(this.answer);
-    } else {
-      message += this.getMaskedValue(this.rl.line || '');
-    }
+    message +=
+      this.status === 'answered'
+        ? this.getMaskedValue(this.answer)
+        : this.getMaskedValue(this.rl.line || '');
 
     if (error) {
       bottomContent = '\n' + chalk.red('>> ') + error;

packages/inquirer/lib/prompts/rawlist.js

@@ -150,17 +150,13 @@ export default class RawListPrompt extends Base {
     let index;
 
     if (this.lastKey === 'arrow') {
-      index = this.hiddenLine.length ? Number(this.hiddenLine) - 1 : 0;
+      index = this.hiddenLine.length > 0 ? Number(this.hiddenLine) - 1 : 0;
     } else {
-      index = this.rl.line.length ? Number(this.rl.line) - 1 : 0;
+      index = this.rl.line.length > 0 ? Number(this.rl.line) - 1 : 0;
     }
     this.lastKey = '';
 
-    if (this.opt.choices.getChoice(index)) {
-      this.selected = index;
-    } else {
-      this.selected = undefined;
-    }
+    this.selected = this.opt.choices.getChoice(index) ? index : undefined;
     this.render();
   }
 

packages/inquirer/lib/ui/bottom-bar.js

@@ -80,7 +80,7 @@ export default class BottomBar extends Base {
     this.height = msgLines.length;
 
     // Write message to screen and setPrompt to control backspace
-    this.rl.setPrompt(msgLines[msgLines.length - 1]);
+    this.rl.setPrompt(msgLines.at(-1));
 
     if (this.rl.output.rows === 0 && this.rl.output.columns === 0) {
       /* When it's a tty through serial port there's no terminal info and the render will malfunction,

packages/inquirer/lib/ui/prompt.js

@@ -23,11 +23,7 @@ export default class PromptUI extends Base {
 
   run(questions, answers) {
     // Keep global reference to the answers
-    if (_.isPlainObject(answers)) {
-      this.answers = { ...answers };
-    } else {
-      this.answers = {};
-    }
+    this.answers = _.isPlainObject(answers) ? { ...answers } : {};
 
     // Make sure questions is an array.
     if (_.isPlainObject(questions)) {

packages/inquirer/lib/utils/events.js

@@ -31,7 +31,7 @@ export default function (rl) {
     ),
 
     numberKey: keypress.pipe(
-      filter((e) => e.value && '123456789'.indexOf(e.value) >= 0),
+      filter((e) => e.value && '123456789'.includes(e.value)),
       map((e) => Number(e.value)),
       share(),
     ),

packages/inquirer/lib/utils/screen-manager.js

@@ -67,7 +67,7 @@ export default class ScreenManager {
     // rl.line (mainly because of the password prompt), so just rely on it's
     // length.
     let prompt = rawPromptLine;
-    if (this.rl.line.length) {
+    if (this.rl.line.length > 0) {
       prompt = prompt.slice(0, -this.rl.line.length);
     }
 

packages/inquirer/test/specs/prompts/input.js

@@ -36,7 +36,7 @@ describe('`input` prompt', () => {
 
   it('should apply the provided transform to the value', function (done) {
     this.fixture.transformer = function (value) {
-      return value.split('').reverse().join('');
+      return [...value].reverse().join('');
     };
 
     const prompt = new Input(this.fixture, this.rl);

packages/inquirer/test/specs/prompts/number.test.js

@@ -80,7 +80,7 @@ describe('`number` prompt', () => {
   it('should parse a float with no digits before the decimal', () =>
     new Promise((done) => {
       number.run().then((answer) => {
-        expect(answer).toBeCloseTo(0.01264, ACCEPTABLE_ERROR);
+        expect(answer).toBeCloseTo(0.012_64, ACCEPTABLE_ERROR);
         done();
       });
 

packages/rawlist/src/index.mts

@@ -44,7 +44,7 @@ export default createPrompt(
       if (isEnterKey(key)) {
         let selectedChoice;
         if (numberRegex.test(value)) {
-          const answer = parseInt(value, 10) - 1;
+          const answer = Number.parseInt(value, 10) - 1;
           selectedChoice = choices.filter(isSelectableChoice)[answer];
         } else {
           const answer = value.toLowerCase();

packages/testing/src/index.mts

@@ -33,7 +33,7 @@ class BufferedStream extends Stream.Writable {
 
   getLastChunk({ raw }: { raw?: boolean }): string {
     const chunks = raw ? this.#_rawChunks : this.#_chunks;
-    const lastChunk = chunks[chunks.length - 1];
+    const lastChunk = chunks.at(-1);
     return lastChunk ?? '';
   }