WIP: Handle errors gracefully

SBoudrias · Apr 23, 2023 · ddaec71 · ddaec71
1 parent bbd7a52
commit ddaec71
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 12 deletions.
diff --git a/packages/core/src/index.mts b/packages/core/src/index.mts
@@ -132,7 +132,7 @@ export function createPrompt<Value, Config extends AsyncPromptConfig>(
     // TODO: we should display a loader while we get the default options.
     const resolvedConfig = await getPromptConfig(config);
 
-    return new Promise((resolve) => {
+    return new Promise((resolve, reject) => {
       const done = (value: Value) => {
         let len = hooksCleanup.length;
         while (len--) {
@@ -155,18 +155,22 @@ export function createPrompt<Value, Config extends AsyncPromptConfig>(
       };
 
       const workLoop = () => {
-        index = 0;
-        hooksEffect.length = 0;
-        handleChange = () => workLoop();
-
-        const nextView = view(resolvedConfig, done);
-        for (const effect of hooksEffect) {
-          effect();
+        try {
+          index = 0;
+          hooksEffect.length = 0;
+          handleChange = () => workLoop();
+
+          const nextView = view(resolvedConfig, done);
+          for (const effect of hooksEffect) {
+            effect();
+          }
+
+          const [content, bottomContent] =
+            typeof nextView === 'string' ? [nextView] : nextView;
+          screen.render(content, bottomContent);
+        } catch (err) {
+          reject(err);
         }
-
-        const [content, bottomContent] =
-          typeof nextView === 'string' ? [nextView] : nextView;
-        screen.render(content, bottomContent);
       };
 
       workLoop();

diff --git a/packages/input/test.mts b/packages/input/test.mts
@@ -93,6 +93,20 @@ describe('input prompt', () => {
     await expect(answer).resolves.toEqual('2');
   });
 
+  it('handle errors in validation gracefully', async () => {
+    const { answer, events, getScreen } = await render(input, {
+      message: 'Answer 2 ===',
+      validate() {
+        return Promise.reject(new Error('Validation error'));
+      },
+    });
+
+    events.type('1');
+    events.keypress('enter');
+    await expect(answer).rejects.toThrowError('Validation error');
+    expect(getScreen()).toMatchInlineSnapshot();
+  });
+
   it('handle default option', async () => {
     const { answer, events, getScreen } = await render(input, {
       message: 'What is your name',